Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the excessive #[allow(clippy::missing_inline_in_public_items)] #179

Closed
jonas-schievink opened this issue Nov 28, 2019 · 1 comment · Fixed by #313
Closed

Remove the excessive #[allow(clippy::missing_inline_in_public_items)] #179

jonas-schievink opened this issue Nov 28, 2019 · 1 comment · Fixed by #313
Labels
blocked

Comments

@jonas-schievink
Copy link
Contributor

These were added in #175 because the lint fires on #[derive(Debug)]-generated impls. Once rust-lang/rust-clippy#4861 is fixed on stable, the #[allow]s should be removed from all structs.
@jonas-schievink
Copy link
Contributor Author

Upstream bug has been fixed, the first Rust version with the fix will likely be 1.41

@jonas-schievink jonas-schievink mentioned this issue Jan 7, 2021
Merged
@bors bors bot closed this as completed in d4cbf07 Jan 7, 2021
adamgreig pushed a commit that referenced this issue Jan 12, 2022
@bors @raz-a
Merge #179
6898ce8 
179: Fix incorrect __EXCEPTIONS in lib.rs comment r=therealprof a=raz-a

Update lib.rs comment describing __INTERRUPTS variable to say __INTERRUPTS instead of __EXCEPTIONS

Co-authored-by: Raz Aloni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove excessive #[allow(clippy::missing_inline_in_public_items)]
1 participant
@jonas-schievink