Enable the missing_inline_in_public_items clippy lint. #175
Conversation
|
r? @thejpster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
Could we add a comment that explains under which circumstances it's appropriate to use the |
Done! |
This sounds like a bug in the lint – it's not really appropriate to warn about code the user doesn't control. I filed rust-lang/rust-clippy#4861 to track this. |
There was a problem hiding this comment.
Changes look good to me, thanks!
We should probably file an issue about the #[derive(Debug)] issue so we don't forget to remove all those #[allow]s once rust-lang/rust-clippy#4861 is fixed.
|
bors r=jonas-schievink |
175: Enable the missing_inline_in_public_items clippy lint. r=jonas-schievink a=m-ou-se This adds `#![deny(clippy::missing_inline_in_public_items)]` to make sure all functions in this crate are marked `#[inline]`, unless they are explicitly marked with `#[allow(clippy::missing_inline_in_public_items)]`. Only three functions in this crate are not `#[inline]`: - `write_words` - `write_all` - `write_aligned` Additionally, the derived `Debug` impl's also have a non-inline implementations. This unfortunately means that the allow attribute also needs to added to any types deriving `Debug`. See also #171 and #174 (comment). Co-authored-by: Mara Bos <[email protected]>
Build succeeded |
This adds
#![deny(clippy::missing_inline_in_public_items)]to make sure all functions in this crate are marked#[inline], unless they are explicitly marked with#[allow(clippy::missing_inline_in_public_items)].Only three functions in this crate are not
#[inline]:write_wordswrite_allwrite_alignedAdditionally, the derived
Debugimpl's also have a non-inline implementations.This unfortunately means that the allow attribute also needs to added to any types deriving
Debug.See also #171 and #174 (comment).