Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: empty stderr if check-fail -> check-pass #134196

Closed
jieyouxu opened this issue Dec 12, 2024 · 0 comments · Fixed by #134808
Closed

compiletest: empty stderr if check-fail -> check-pass #134196

jieyouxu opened this issue Dec 12, 2024 · 0 comments · Fixed by #134808
Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Dec 12, 2024 •
edited
Loading

What the heck xD I blessed all ui tests in all commits...

Hm, this might be a compiletest bug, where if u had a previous stderr from check-fail then u change it to check-pass it might write empty stderr but keep the file... I'll open an issue later.

Originally posted by @jieyouxu in #134070 (comment)
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 12, 2024
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-compiletest Area: The compiletest test runner E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 12, 2024
@jieyouxu jieyouxu mentioned this issue Dec 27, 2024
Merged
@bors bors closed this as completed in 7ba9655 Dec 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 27, 2024
@rust-timer
Unrolled build for rust-lang#134808
56a0816 
Rollup merge of rust-lang#134808 - clubby789:compiletest-remove-stderr, r=jieyouxu

compiletest: Remove empty 'expected' files when blessing

Fixes rust-lang#134793
Fixes rust-lang#134196

This also refactors `compare_output` to return an enum; returning a usize was done for convenience but is misleading
poliorcetics pushed a commit to poliorcetics/rust that referenced this issue Dec 28, 2024
@matthiaskrgr @poliorcetics
Rollup merge of rust-lang#134808 - clubby789:compiletest-remove-stder…
db6ba90 
…r, r=jieyouxu

compiletest: Remove empty 'expected' files when blessing

Fixes rust-lang#134793
Fixes rust-lang#134196

This also refactors `compare_output` to return an enum; returning a usize was done for convenience but is misleading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compiletest: Remove empty 'expected' files when blessing clubby789/rust
2 participants
@jieyouxu @rustbot