compiletest "--bless" fails to delete stderr files #134793
Labels
A-compiletest
Area: The compiletest test runner
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
rustbot
added
the
needs-triage
jieyouxu
added
T-compiler
github-project-automation
bot
moved this from Backlog
to Done
in compiletest maintenance and improvements
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 27, 2024
Rollup merge of rust-lang#134808 - clubby789:compiletest-remove-stderr, r=jieyouxu compiletest: Remove empty 'expected' files when blessing Fixes rust-lang#134793 Fixes rust-lang#134196 This also refactors `compare_output` to return an enum; returning a usize was done for convenience but is misleading
poliorcetics
pushed a commit
to poliorcetics/rust
that referenced
this issue
Dec 28, 2024
…r, r=jieyouxu compiletest: Remove empty 'expected' files when blessing Fixes rust-lang#134793 Fixes rust-lang#134196 This also refactors `compare_output` to return an enum; returning a usize was done for convenience but is misleading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I made a mistake during compiler development so that a "--bless" run (
./x test ui --bless -- feat) ended up generating a bunch of stderr files for compiler runs that shouldn't fail. I fixed that mistake, but unfortunately "--bless" does not remove these files. It seems I have to delete them all by hand.That's not great; if "--bless" creates new files then it should also clean them up by itself.
The text was updated successfully, but these errors were encountered: