Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM function pass test and LLVM module pass test #31185

Closed
frewsxcv opened this issue Jan 25, 2016 · 2 comments
Closed

Add LLVM function pass test and LLVM module pass test #31185

frewsxcv opened this issue Jan 25, 2016 · 2 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.

Comments

@frewsxcv
Copy link
Member

To prevent #31067 from occurring again

At the time of writing, this is the only LLVM pass test we have in the suite:

https://github.com/rust-lang/rust/blob/master/src/test/auxiliary/llvm_pass_plugin.rs

which is testing a built-in pass and not a custom one.

@steveklabnik steveklabnik added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Jan 26, 2016
@nagisa nagisa added the E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. label Jan 27, 2016
@frewsxcv
Copy link
Member Author

I'll take a stab at this

frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 4, 2016
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 5, 2016
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 14, 2016
bors added a commit that referenced this issue Feb 14, 2016
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 15, 2016
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 15, 2016
bors added a commit that referenced this issue Feb 16, 2016
@frewsxcv
Copy link
Member Author

Done in #31391 and #31669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
Projects
None yet
Development

No branches or pull requests

3 participants