Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LLVM FunctionPass regression test using run-make. #31669

Merged
merged 1 commit into from
Feb 16, 2016
Merged

Add LLVM FunctionPass regression test using run-make. #31669

merged 1 commit into from
Feb 16, 2016
+78 −17

Conversation

frewsxcv
Copy link
Member

Part of #31185.

Similar to #31391.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv changed the title Add LLVM ModulePass regression test using run-make. Add LLVM FunctionPass regression test using run-make. Feb 15, 2016
@frewsxcv frewsxcv force-pushed the llvm-function-pass-rmake-test branch from a5672b9 to 8c14a60 Compare February 15, 2016 04:04
@frewsxcv
Copy link
Member Author

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned brson Feb 15, 2016
@alexcrichton
Copy link
Member

Could this just get folded into the existing test? Would help deduplicate among them

@frewsxcv frewsxcv force-pushed the llvm-function-pass-rmake-test branch from 8c14a60 to a60ec05 Compare February 15, 2016 15:08
@frewsxcv
Copy link
Member Author

@alexcrichton Good idea! Latest force push has them merged into one rmake test

@alexcrichton
Copy link
Member

@bors: r+ a60ec05

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 15, 2016
@Manishearth
Rollup merge of rust-lang#31669 - frewsxcv:llvm-function-pass-rmake-t…
4e50134 
…est, r=alexcrichton

Part of rust-lang#31185.

Similar to rust-lang#31391.
@Manishearth
Copy link
Member

This may have cause the failure here

@frewsxcv
Copy link
Member Author

My guess is that #31672 is the problematic one here, but I'm not entirely sure why...

@bors
Copy link
Contributor

bors commented Feb 16, 2016

⌛ Testing commit a60ec05 with merge 0bf6394...

bors added a commit that referenced this pull request Feb 16, 2016
@bors
Auto merge of #31669 - frewsxcv:llvm-function-pass-rmake-test, r=alex…
0bf6394 
…crichton

Part of #31185.

Similar to #31391.
@bors
Copy link
Contributor

bors commented Feb 16, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit a60ec05 into rust-lang:master Feb 16, 2016
@frewsxcv frewsxcv deleted the llvm-function-pass-rmake-test branch February 16, 2016 13:12
@frewsxcv frewsxcv mentioned this pull request Feb 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@frewsxcv @rust-highfive @alexcrichton @Manishearth @bors @brson