Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustdoc --check to rustdoc's docs #92763

Closed
edmorley opened this issue Jan 11, 2022 · 5 comments
Closed

Add rustdoc --check to rustdoc's docs #92763

edmorley opened this issue Jan 11, 2022 · 5 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@edmorley
Copy link
Contributor

Support for rustdoc --check was added in #78984, and it can be seen in the output from rustdoc --help:

$ rustdoc --help
...
        --check         Run rustdoc checks

However there is no mention of it on:
https://doc.rust-lang.org/rustdoc/command-line-arguments.html

Which is built from:
https://github.com/rust-lang/rust/blob/e4b1d5841494d6eb7f4944c91a057e16b0f0a9ea/src/doc/rustdoc/src/command-line-arguments.md

@GuillaumeGomez
Copy link
Member

Thanks for opening this issue! Want to send a PR for it maybe? :)

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 11, 2022
@edmorley
Copy link
Contributor Author

Comparing rustdoc --help and that docs page, I see a few other inconsistencies. It seems that having the page be auto-generated might be more sustainable longer term?

I can open a PR for this instance in the meantime, however.

@edmorley
Copy link
Contributor Author

Hmm all of these are missing too:

    -A, --allow LINT    Set lint allowed
    -W, --warn LINT     Set lint warnings
        --force-warn LINT
                        Set lint force-warn
    -D, --deny LINT     Set lint denied
    -F, --forbid LINT   Set lint forbidden

I think I might skip a PR for now, since really the whole doc needs careful review.

@GuillaumeGomez
Copy link
Member

Comparing rustdoc --help and that docs page, I see a few other inconsistencies. It seems that having the page be auto-generated might be more sustainable longer term?

I'm not sure auto-generated would work nicely... The best would maybe to add a check for it like we do for a few other things.

I can open a PR for this instance in the meantime, however.

That would be very appreciated!

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 16, 2022
…iddle

rustdoc --check option documentation

Part of rust-lang#92763.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 16, 2022
…iddle

rustdoc --check option documentation

Part of rust-lang#92763.

r? ``@notriddle``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 16, 2022
…iddle

rustdoc --check option documentation

Part of rust-lang#92763.

r? ```@notriddle```
@GuillaumeGomez
Copy link
Member

Fixed in #94015.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants