[WIP] Migrate rustc_ast_passes diagnostics to SessionDiagnostic and translatable messages (second part) #101657

finalchild · 2022-09-10T15:33:09Z

Second (and hopefully last) PR migrating rustc_ast_passes to SessionDiagnostics.

@rustbot label +A-translation

rust-highfive · 2022-09-10T15:33:12Z

(rust-highfive has picked a reviewer for you, use r? to override)

finalchild · 2022-09-10T16:52:23Z

I don't understand how the CI job failed.

error[E0599]: no variant or associated item named `Type` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:173:32
    |
173 |             ast::ParamKindOrd::Type => "type",
    |                                ^^^^ variant or associated item not found in `ParamKindOrd`

error[E0599]: no variant or associated item named `Const` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:174:32
    |
174 |             ast::ParamKindOrd::Const => "const",
    |                                ^^^^^ variant or associated item not found in `ParamKindOrd`

error[E0599]: no variant or associated item named `Infer` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:175:32
    |
175 |             ast::ParamKindOrd::Infer => "infer",
    |                                ^^^^^ variant or associated item not found in `ParamKindOrd`

Maybe some kind of incremental build issue? Is there a way to clean the cache of CI?

RanolP · 2022-09-11T02:38:20Z

I don't understand how the CI job failed.

error[E0599]: no variant or associated item named `Type` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:173:32
    |
173 |             ast::ParamKindOrd::Type => "type",
    |                                ^^^^ variant or associated item not found in `ParamKindOrd`

error[E0599]: no variant or associated item named `Const` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:174:32
    |
174 |             ast::ParamKindOrd::Const => "const",
    |                                ^^^^^ variant or associated item not found in `ParamKindOrd`

error[E0599]: no variant or associated item named `Infer` found for enum `ParamKindOrd` in the current scope
   --> compiler/rustc_errors/src/diagnostic.rs:175:32
    |
175 |             ast::ParamKindOrd::Infer => "infer",
    |                                ^^^^^ variant or associated item not found in `ParamKindOrd`

Maybe some kind of incremental build issue? Is there a way to clean the cache of CI?

I think ae49732 caused the error on your code. The commit has changed the ParamKindOrd, you're trying to impl, from master. Therefore, you'll need to follow up on those changes.

lcnr · 2022-09-12T08:50:17Z

r? @davidtwco

compiler/rustc_ast_passes/src/ast_validation.rs

davidtwco · 2022-09-13T09:09:48Z

Are you looking to land this or still working on it?

finalchild · 2022-09-13T10:04:48Z

There's one more file to migrate!

davidtwco

Apologies for the delay in reviewing.

davidtwco · 2022-11-03T15:51:24Z

compiler/rustc_ast_passes/src/errors.rs

+    pub(crate) reason: &'a DisallowTildeConstContext<'b>,
+}
+
+impl<'a> AddToDiagnostic for &'a DisallowTildeConstContext<'_> {


Can't the derive be used for this?

davidtwco · 2022-11-03T15:51:49Z

compiler/rustc_ast_passes/src/errors.rs

+    pub suggestion: Vec<(Span, String)>,
+}
+
+impl AddToDiagnostic for EqualityConstraintToAssocConstraintSuggestion {


Can the derive be used for this?

davidtwco · 2022-11-03T15:52:18Z

compiler/rustc_error_messages/locales/en-US/ast_passes.ftl

+       *[type_or_const] type and const
+    } parameters must be declared prior to { $max_param_kind ->
+        [lifetime] lifetime
+       *[type_or_const] type and const


Can these be split into multiple Fluent messages to avoid pattern matching on strings?

bors · 2022-11-24T03:59:32Z

☔ The latest upstream changes (presumably #104507) made this pull request unmergeable. Please resolve the merge conflicts.

…mangleItemNonAscii

…athParam, ImplTraitTyNested, ImplTraitTyWithoutTraitBound, deprecated_extern_missing_abi

Co-authored-by: RanolP <[email protected]>

…cConstraintSuggestion

bors · 2023-02-21T10:12:57Z

☔ The latest upstream changes (presumably #104754) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive assigned lcnr Sep 10, 2022

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 10, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2022

This comment has been minimized.

Sign in to view

finalchild force-pushed the ast-passes-diag-2 branch from 5c81f5a to 1e828ee Compare September 11, 2022 07:36

rust-highfive assigned davidtwco and unassigned lcnr Sep 12, 2022

davidtwco reviewed Sep 12, 2022

View reviewed changes

compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved

davidtwco approved these changes Sep 13, 2022

View reviewed changes