Use `ThinVec` more in the AST #104754

nnethercote · 2022-11-23T01:53:20Z

r? @ghost

rustbot · 2022-11-23T01:53:25Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

nnethercote · 2022-11-23T01:53:31Z

@bors try @rust-timer queue

bors · 2022-11-23T01:53:39Z

⌛ Trying commit 26324d59c93e8eb9d08792a57b02990185a45852 with merge 10ea77cebafccd3c9085348ddf5b678008e8a87c...

bors · 2022-11-23T03:55:23Z

☀️ Try build successful - checks-actions
Build commit: 10ea77cebafccd3c9085348ddf5b678008e8a87c (10ea77cebafccd3c9085348ddf5b678008e8a87c)

rust-timer · 2022-11-23T07:54:55Z

Finished benchmarking commit (10ea77cebafccd3c9085348ddf5b678008e8a87c): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	3
Regressions ❌ (secondary)	0.8%	[0.3%, 1.2%]	14
Improvements ✅ (primary)	-0.5%	[-0.9%, -0.2%]	29
Improvements ✅ (secondary)	-0.4%	[-0.8%, -0.1%]	20
All ❌✅ (primary)	-0.4%	[-0.9%, 0.4%]	32

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[1.2%, 3.6%]	16
Improvements ✅ (primary)	-1.3%	[-2.1%, -0.5%]	2
Improvements ✅ (secondary)	-2.1%	[-3.7%, -1.2%]	3
All ❌✅ (primary)	-1.3%	[-2.1%, -0.5%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.4%	[-4.4%, -4.4%]	1
All ❌✅ (primary)	-	-	0

nnethercote · 2022-11-24T23:50:55Z

Let's try again, see if the bootstrapping improvement persists.

@bors try @rust-timer queue

bors · 2022-11-24T23:51:06Z

⌛ Trying commit 4ce53b1508cf82969ed83a009865aaece57280e8 with merge e027f83413d67db20d22ecd9ad55315b279b09e2...

bors · 2022-11-25T01:57:52Z

☀️ Try build successful - checks-actions
Build commit: e027f83413d67db20d22ecd9ad55315b279b09e2 (e027f83413d67db20d22ecd9ad55315b279b09e2)

rust-timer · 2022-11-25T03:44:33Z

Finished benchmarking commit (e027f83413d67db20d22ecd9ad55315b279b09e2): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.5%, 1.2%]	5
Improvements ✅ (primary)	-0.5%	[-1.3%, -0.2%]	77
Improvements ✅ (secondary)	-0.6%	[-1.3%, -0.2%]	38
All ❌✅ (primary)	-0.5%	[-1.3%, -0.2%]	77

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[1.8%, 6.8%]	18
Improvements ✅ (primary)	-1.3%	[-2.9%, -0.5%]	3
Improvements ✅ (secondary)	-2.7%	[-3.2%, -2.1%]	2
All ❌✅ (primary)	-1.3%	[-2.9%, -0.5%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.3%, 2.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

nnethercote · 2022-11-25T04:19:28Z

Wow, this time the bootstrap improvement was 7.9 seconds (1.15%). And the instruction count results were good too. I think this is worth going forward.

r? @the8472

the8472

Overall a fairly mechanical replacement that looks fine. Only two issues in clippy code. Those probably would only become an issue if someone code-generates huge patterns and then runs clippy on them

src/tools/clippy/clippy_lints/src/unnested_or_patterns.rs

compiler/rustc_ast/src/ast.rs

src/test/ui/stats/hir-stats.stderr

nnethercote · 2022-12-01T00:15:15Z

I rebased.

…when in parallel_compiler mode.

nnethercote · 2023-02-21T01:34:27Z

It works!

@bors try @rust-timer queue

bors · 2023-02-21T01:34:36Z

⌛ Trying commit 9c7570b with merge 501502d1c672413aad29cf862cc45a53ac8c53c8...

bors · 2023-02-21T04:27:48Z

☀️ Try build successful - checks-actions
Build commit: 501502d1c672413aad29cf862cc45a53ac8c53c8 (501502d1c672413aad29cf862cc45a53ac8c53c8)

rust-timer · 2023-02-21T05:45:46Z

Finished benchmarking commit (501502d1c672413aad29cf862cc45a53ac8c53c8): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.8%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-1.5%, -0.2%]	76
Improvements ✅ (secondary)	-0.8%	[-3.3%, -0.2%]	42
All ❌✅ (primary)	-0.4%	[-1.5%, 0.8%]	84

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	3.0%	[1.1%, 5.1%]	9
Improvements ✅ (primary)	-1.1%	[-1.2%, -1.1%]	2
Improvements ✅ (secondary)	-2.8%	[-5.2%, -1.2%]	9
All ❌✅ (primary)	-0.4%	[-1.2%, 1.0%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

nnethercote · 2023-02-21T05:51:09Z

Perf results are still good.

@bors r=the8472

bors · 2023-02-21T05:51:11Z

📌 Commit 9c7570b has been approved by the8472

It is now in the queue for this repository.

bors · 2023-02-21T07:03:00Z

⌛ Testing commit 9c7570b with merge 3fee48c...

bors · 2023-02-21T09:50:56Z

☀️ Test successful - checks-actions
Approved by: the8472
Pushing 3fee48c to master...

rust-timer · 2023-02-21T11:25:50Z

Finished benchmarking commit (3fee48c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.6%]	9
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-1.5%, -0.2%]	80
Improvements ✅ (secondary)	-0.8%	[-3.3%, -0.2%]	44
All ❌✅ (primary)	-0.4%	[-1.5%, 0.6%]	89

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.2%, 4.1%]	8
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-3.5%	[-9.6%, -1.1%]	14
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 23, 2022

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 23, 2022

nnethercote force-pushed the more-ThinVec-in-ast branch from 26324d5 to 4ce53b1 Compare November 24, 2022 23:50

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 24, 2022

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 25, 2022

rustbot assigned the8472 Nov 25, 2022

the8472 reviewed Nov 30, 2022

View reviewed changes

nnethercote force-pushed the more-ThinVec-in-ast branch from 4ce53b1 to 44d103d Compare December 1, 2022 00:13

nnethercote and others added 4 commits February 21, 2023 11:51

Use ThinVec in a few more AST types.

7e855d5

Allow disabling of auto and blanket trait impls retrieval in rustdoc …

953a71a

…when in parallel_compiler mode.

Enable --cfg=parallel_compiler in rustdoc.

c7f443a

Fix a test.

9c7570b

nnethercote force-pushed the more-ThinVec-in-ast branch from b6f6cd8 to 9c7570b Compare February 21, 2023 01:34

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 21, 2023

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Feb 21, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 21, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 21, 2023

bors merged commit 3fee48c into rust-lang:master Feb 21, 2023

rustbot added this to the 1.69.0 milestone Feb 21, 2023

This was referenced Feb 21, 2023

[WIP] Migrate rustc_ast_passes diagnostics to SessionDiagnostic and translatable messages (second part) #101657

Closed

DO NOT REVIEW - CoAllocation - 06 vec macroed squash fmt workaround #108274

Closed

nnethercote deleted the more-ThinVec-in-ast branch February 21, 2023 21:22

klensy mentioned this pull request Feb 21, 2023

Bump thin-vec version to pick up inline attributes #108245

Closed

Boshen mentioned this pull request Mar 27, 2023

perf(ast): ThinVec oxc-project/oxc#217

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `ThinVec` more in the AST #104754

Use `ThinVec` more in the AST #104754

nnethercote commented Nov 23, 2022

rustbot commented Nov 23, 2022

nnethercote commented Nov 23, 2022

This comment has been minimized.

bors commented Nov 23, 2022

bors commented Nov 23, 2022

This comment has been minimized.

rust-timer commented Nov 23, 2022

nnethercote commented Nov 24, 2022

This comment has been minimized.

bors commented Nov 24, 2022

bors commented Nov 25, 2022

This comment has been minimized.

rust-timer commented Nov 25, 2022

nnethercote commented Nov 25, 2022

the8472 left a comment

nnethercote commented Dec 1, 2022

nnethercote commented Feb 21, 2023

This comment has been minimized.

bors commented Feb 21, 2023

bors commented Feb 21, 2023

This comment has been minimized.

rust-timer commented Feb 21, 2023

nnethercote commented Feb 21, 2023

bors commented Feb 21, 2023

bors commented Feb 21, 2023

bors commented Feb 21, 2023

rust-timer commented Feb 21, 2023

Use ThinVec more in the AST #104754

Use ThinVec more in the AST #104754

Conversation

nnethercote commented Nov 23, 2022

rustbot commented Nov 23, 2022

nnethercote commented Nov 23, 2022

This comment has been minimized.

bors commented Nov 23, 2022

bors commented Nov 23, 2022

This comment has been minimized.

rust-timer commented Nov 23, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

nnethercote commented Nov 24, 2022

This comment has been minimized.

bors commented Nov 24, 2022

bors commented Nov 25, 2022

This comment has been minimized.

rust-timer commented Nov 25, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

nnethercote commented Nov 25, 2022

the8472 left a comment

Choose a reason for hiding this comment

nnethercote commented Dec 1, 2022

nnethercote commented Feb 21, 2023

This comment has been minimized.

bors commented Feb 21, 2023

bors commented Feb 21, 2023

This comment has been minimized.

rust-timer commented Feb 21, 2023

Overall result: ✅ improvements - no action needed

nnethercote commented Feb 21, 2023

bors commented Feb 21, 2023

bors commented Feb 21, 2023

bors commented Feb 21, 2023

rust-timer commented Feb 21, 2023

Overall result: ✅ improvements - no action needed

Use `ThinVec` more in the AST #104754

Use `ThinVec` more in the AST #104754