Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove repeated definite articles #110804

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Remove repeated definite articles #110804

merged 1 commit into from
Apr 27, 2023

Conversation

cuishuang
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2023

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

jyn514
jyn514 suggested changes Apr 26, 2023
View reviewed changes
src/tools/rustfmt/CHANGELOG.md Outdated Show resolved Hide resolved
src/tools/rustfmt/Processes.md Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

Thanks! could you please squash the commits so the intermediate commit doesn't modify rustfmt? there's instructions at https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing. Happy to approve with that done :)

@cuishuang
Copy link
Contributor Author

Thanks! could you please squash the commits so the intermediate commit doesn't modify rustfmt? there's instructions at https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing. Happy to approve with that done :)

Of course.
Done

@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 26, 2023

📌 Commit ef6d4c5 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 26, 2023
@matthiaskrgr
Rollup merge of rust-lang#110804 - cuishuang:master, r=jyn514
b9d023f 
Remove repeated definite articles
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 26, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 27, 2023
@matthiaskrgr
Rollup merge of rust-lang#110804 - cuishuang:master, r=jyn514
2647953 
Remove repeated definite articles
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 27, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2023
@bors
Auto merge of rust-lang#110896 - matthiaskrgr:rollup-h8fetzd, r=matth…
901fdb3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#110426 (docs(style): add more let-else examples)
 - rust-lang#110804 (Remove repeated definite articles)
 - rust-lang#110814 (Sprinkle some `#[inline]` in `rustc_data_structures::tagged_ptr`)
 - rust-lang#110816 (Migrate `rustc_passes` to translatable diagnostics)
 - rust-lang#110864 (`IntoFuture::into_future` is no longer unstable)
 - rust-lang#110866 (Make `method-not-found-generic-arg-elision.rs` error message not path dependent)
 - rust-lang#110872 (Nicer ICE for rust-lang#67981)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5215782 into rust-lang:master Apr 27, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

@jyn514 jyn514 jyn514 requested changes

Assignees

@jackh726 jackh726

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cuishuang @rustbot @jyn514 @bors @lnicola @jackh726