Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #110868

Closed
wants to merge 15 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ijackson and others added 15 commits January 3, 2023 20:58
Even where actually running processes is not supported.
Needed for the next commit.

The manual trait implementations now belong on ExitStatusError,
which still can't exist.
The infra-team is continuously monitoring the efficiency of the build
system in an effort to improve overall build times and resource usage.
The builders for the `i686-gnu` targets have used much less resources
than allocated in the past, so we are testing a smaller builder size for
them.
The infra-team is continuously monitoring the efficiency of the build
system in an effort to improve overall build times and resource usage.
The builder for the `mingw-check` target have used much less resources
than allocated in the past, so we are testing a smaller builder size for
it.
The infra-team is continuously monitoring the efficiency of the build
system in an effort to improve overall build times and resource usage.
The builders for some of the `x86_64-gnu` targets have used much less
resources than allocated in the past, so we are testing a smaller
builder size for them.
…omcc

Make ExitStatus implement Default

And, necessarily, make it inhabited even on platforms without processes.

I noticed while preparing rust-lang/rfcs#3362 that there was no way for anyone to construct an `ExitStatus`.

This would be insta-stable so needs an FCP.
…mples, r=compiler-errors

docs(style): add more let-else examples

Adding a few more examples for increased clarity based on subsequent discussion that arose after implementation work began.

Will need approval from t-style, but also cc `@ytmimi` to make sure these examples don't contradict any examples we've been incorporating as part of the rustfmt implementation
…ilstrieb

Sprinkle some `#[inline]` in `rustc_data_structures::tagged_ptr`

This is based on `nm --demangle (rustc +a --print sysroot)/lib/librustc_driver-*.so | rg CopyTaggedPtr` which shows many methods that should probably be inlined. May fix the regression in rust-lang#110795.

r? `@Nilstrieb`
…, r=compiler-errors

Migrate `rustc_passes` to translatable diagnostics

cc rust-lang#100717
…oalbini

Optimize builder sizes

The infra-team is continuously monitoring the efficiency of the CI system in an effort to improve overall build times and resource usage. Some builders have used much less than their allocated resources, so we are testing smaller builder sizes for them.

r? `@pietroalbini`
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-style Relevant to the style team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 26, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Apr 26, 2023

📌 Commit 769e859 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
@bors
Copy link
Contributor

bors commented Apr 27, 2023

⌛ Testing commit 769e859 with merge ee2a104407b73b9887cbe8de9c85ecdad393f094...

@rust-log-analyzer
Copy link
Collaborator

The job dist-various-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] object test:false 5.127
error[E0277]: the trait bound `process_inner::ExitStatus: core::default::Default` is not satisfied
    --> library/std/src/process.rs:1519:23
     |
1517 | #[derive(PartialEq, Eq, Clone, Copy, Debug, Default)]
1518 | #[stable(feature = "process", since = "1.0.0")]
1518 | #[stable(feature = "process", since = "1.0.0")]
1519 | pub struct ExitStatus(imp::ExitStatus);
     |                       ^^^^^^^^^^^^^^^ the trait `core::default::Default` is not implemented for `process_inner::ExitStatus`
    ::: /rustc/ee2a104407b73b9887cbe8de9c85ecdad393f094/library/core/src/default.rs:185:1
     |
185  | pub macro Default($item:item) {
     | ----------------- in this expansion of `#[derive(Default)]`
     | ----------------- in this expansion of `#[derive(Default)]`
     |
help: consider annotating `process_inner::ExitStatus` with `#[derive(Default)]`
    -->  library/std/src/sys/unix/process/process_fuchsia.rs:239:1
239  + #[derive(Default)]
239  + #[derive(Default)]
240  |         f.debug_struct("Child")

For more information about this error, try `rustc --explain E0277`.
[RUSTC-TIMING] std test:false 1.776
error: could not compile `std` due to previous error

@bors
Copy link
Contributor

bors commented Apr 27, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 27, 2023
@matthiaskrgr matthiaskrgr deleted the rollup-yuzabn5 branch March 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-style Relevant to the style team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants