rustdoc: Fixes with --test-run-directory and relative paths. #112751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup Looks good, thanks! And thanks for the thorough descriptions on the linked issues. They really helped to understand what is going on. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 17, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112751 (rustdoc: Fixes with --test-run-directory and relative paths.) - rust-lang#114749 (Update `mpsc::Sender` doc to reflect that it implements `Sync`) - rust-lang#114876 (Don't ICE in `is_trivially_sized` when encountering late-bound self ty) - rust-lang#114881 (clarify CStr lack of layout guarnatees) - rust-lang#114921 (Remove Folyd from librustdoc static files) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112191
Fixes #112210
This fixes some issues with
--test-run-directoryand its interaction with--runtooland--persist-doctests. Relative directories don't work withCommand::current_dirvery well because it has platform-specific behavior with relative paths. This fixes it by avoiding the use of relative paths.This is needed because cargo is switching to use
--test-run-directory, and it uses relative paths when interacting with rustdoc/rustc.