Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mpsc::Sender doc to reflect that it implements Sync #114749

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Update mpsc::Sender doc to reflect that it implements Sync #114749

merged 1 commit into from
Aug 17, 2023

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Aug 12, 2023

Fixes #114722

@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 12, 2023
@gurry
Copy link
Contributor Author

gurry commented Aug 17, 2023

@thomcc Please take a look

@thomcc
Copy link
Member

thomcc commented Aug 17, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 17, 2023

📌 Commit 0af9dfc has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 17, 2023
@bors
Auto merge of rust-lang#114922 - matthiaskrgr:rollup-qktdihi, r=matth…
d4a881e 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#112751 (rustdoc: Fixes with --test-run-directory and relative paths.)
 - rust-lang#114749 (Update `mpsc::Sender` doc to reflect that it implements `Sync`)
 - rust-lang#114876 (Don't ICE in `is_trivially_sized` when encountering late-bound self ty)
 - rust-lang#114881 (clarify CStr lack of layout guarnatees)
 - rust-lang#114921 (Remove Folyd from librustdoc static files)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f4cd7a5 into rust-lang:master Aug 17, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 17, 2023
@gurry gurry deleted the issue-114722 branch August 17, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Documentation for mpsc::Sender should reflect its Sync trait
4 participants
@gurry @rustbot @thomcc @bors