[compiletest-related cleanups 4/7] Make the distinction between root build directory vs test suite specific build directory in compiletest less confusing
#136542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
…--stage-id` Notably, this avoids having to do hacky string splitting based on `--stage-id`.
Instead of only having `--src-base` and `src_base` which *actually* refers to the directory containing the test suite and not the sources root. More importantly, kill off `find_rust_src_root` when we can simply pass that info from bootstrap.
…ic build dir
- Introduce and use `--build-{root,test-suite-root}` over
`--build-base`.
- A few minor cleanups.
…test-suite-root` instead
rustbot
added
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This PR is stacked on top of #136441, #136472 and #136474. This PR contains their commits, the prerequisite PRs must be merged first, then this PR will need to be rebased.
Reference for overall changes: #136437
Part 4 of 7 of the
compiletest-related cleanups PR series.Summary
--build-basecompiletest flag, and introduce--build-{root,test-suite-root}flags instead.--build-basepreviously actually is test suite specific build directory, not the rootbuild/directory.--build-rootinstead of doing multiple layers of parent unwrapping1 based on the test suite specific build directory.to_path_buf().r? bootstrap
Footnotes
Please do not unwrap the parents. ↩