Retire the legacy Makefile-based run-make test infra
#136581
Open
+155
−760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
|
@rustbot blocked (on prerequisite PRs merging first) |
rustbot
added
S-blocked
jieyouxu
added
the
A-test-infra
|
Thank you very much for starting this, driving this forward together with @Oneirical during GSoC and everyone else, and now finally bringing this to completion! Thanks! 💜❤️😸 |
|
It's amazing to see this after toiling through the seemingly endless pile of Makefiles. This is going to make it so much less of a hassle when contributors write a PR and reviewers answer, "Very nice, but could you add a test?" |
This comment was marked as resolved.
This comment was marked as resolved.
jieyouxu
force-pushed
the
makefile-be-gone
branch
from
1a53c19 to
3278255
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Instead of only having `--src-base` and `src_base` which *actually* refers to the directory containing the test suite and not the sources root. More importantly, kill off `find_rust_src_root` when we can simply pass that info from bootstrap.
…ic build dir
- Introduce and use `--build-{root,test-suite-root}` over
`--build-base`.
- A few minor cleanups.
…test-suite-root` instead
jieyouxu
force-pushed
the
makefile-be-gone
branch
from
3278255 to
aa0ea9a
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
It has served us well, but it's time to retire the `Makefile` support file since this is no longer needed.
And remove outdated requirements to run `run-make` tests on Windows.
No longer needed.
jieyouxu
force-pushed
the
makefile-be-gone
branch
from
aa0ea9a to
45c0df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Currently stacked on top of #136474 and #136542. Can only be merged after the prerequisite PR is merged and then this PR is rebased.
The final piece of porting run-make tests to use Rust #121876.
Closes #121876.
Closes #40713.
Closes #81791 (no longer using
wc).Closes #56475 (no longer a problem in current form of that test; we don't ignore the test on
aarch64-unknown-linux-gnu).Summary
This PR removes the legacy
Makefile-basedrun-maketest infra which has served us well over the years. The legacy infra is no longer needed since we ported all ofMakefile-basedrun-maketests to the newrmake.rsinfra.Additionally, this PR:
tests/run-make/tools.mksince no moreMakefile-based tests remain.tests/run-make/README.mdand rustc-dev-guide docs to remove mention aboutMakefile-basedrun-maketeststriagebot.tomlto stop backlinking to Tracking Issue for portingrun-maketests to use Rust #121876.Thanks to everyone who helped in this effort to modernize the
run-maketest infra and test suite!r? bootstrap