-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of PRs in the queue; Sunday #23593
Conversation
This allows github to render it with formatting.
This commit removes the `IndexMut` impls on `HashMap` and `BTreeMap`, in order to future-proof the API against the eventual inclusion of an `IndexSet` trait. Ideally, we would eventually be able to support: ```rust map[owned_key] = val; map[borrowed_key].mutating_method(arguments); &mut map[borrowed_key]; ``` but to keep the design space as unconstrained as possible, we do not currently want to support `IndexMut`, in case some other strategy will eventually be needed. Code currently using mutating index notation can use `get_mut` instead. [breaking-change] Closes rust-lang#23448
Rustbook already does this.
…eatures. Namely: * `box_syntax` * `box_patterns` * `simd_ffi` * `macro_reexport` cc rust-lang#22820
Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixes rust-lang#23550
@bors: r+ p=20 |
📌 Commit e7d77cf has been approved by |
@bors: force |
⌛ Testing commit e7d77cf with merge 1d1f2c0... |
💔 Test failed - auto-mac-64-nopt-t |
@bors retry |
⌛ Testing commit e7d77cf with merge 1c15687... |
💔 Test failed - auto-mac-64-nopt-t |
@bors: retry force |
⌛ Testing commit e7d77cf with merge 28a5342... |
⛄ The build was interrupted to prioritize another pull request. |
@bors: retry force |
💔 Test failed - auto-mac-32-opt |
@bors: retry |
⌛ Testing commit e7d77cf with merge 34ead18... |
💔 Test failed - auto-mac-64-nopt-t |
…nkro This commit removes the `IndexMut` impls on `HashMap` and `BTreeMap`, in order to future-proof the API against the eventual inclusion of an `IndexSet` trait. Ideally, we would eventually be able to support: ```rust map[owned_key] = val; map[borrowed_key].mutating_method(arguments); &mut map[borrowed_key]; ``` but to keep the design space as unconstrained as possible, we do not currently want to support `IndexMut`, in case some other strategy will eventually be needed. Code currently using mutating index notation can use `get_mut` instead. [breaking-change] Closes rust-lang#23448 r? @gankro
Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixes rust-lang#23550
…s1, r=alexcrichton ...ures. Namely: * `box_syntax` * `box_patterns` * `simd_ffi` * `macro_reexport` cc rust-lang#22820
…excrichton Rustbook already does this.
⌛ Testing commit b4e9106 with merge 809a554... |
💔 Test failed - auto-mac-64-nopt-t |
@bors: retry force |
⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt... |
💔 Test failed - auto-win-64-nopt-t |
Wow, this rollup is very, very unfortunate! |
@bors: retry |
@barosl Most of this is just because buildbot died over the weekend. |
⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt... |
💔 Test failed - auto-win-64-nopt-t |
@bors: retry force |
⚡ Previous build results for auto-linux-64-nopt-t, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t... |
💔 Test failed - auto-win-32-nopt-t |
@bors: retry |
⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt are reusable. Rebuilding only auto-win-32-nopt-t... |
(yay, no Saturday)