Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of PRs in the queue; Sunday #23593

Merged
merged 16 commits into from
Mar 23, 2015
Merged

Rollup of PRs in the queue; Sunday #23593

merged 16 commits into from
Mar 23, 2015

Conversation

Manishearth
Copy link
Member

(yay, no Saturday)

Ms2ger and others added 8 commits March 20, 2015 13:29
This allows github to render it with formatting.
This commit removes the `IndexMut` impls on `HashMap` and `BTreeMap`, in
order to future-proof the API against the eventual inclusion of an
`IndexSet` trait.

Ideally, we would eventually be able to support:

```rust
map[owned_key] = val;
map[borrowed_key].mutating_method(arguments);
&mut map[borrowed_key];
```

but to keep the design space as unconstrained as possible, we do not
currently want to support `IndexMut`, in case some other strategy will
eventually be needed.

Code currently using mutating index notation can use `get_mut` instead.

[breaking-change]

Closes rust-lang#23448
Rustbook already does this.
…eatures.

Namely:

 * `box_syntax`
 * `box_patterns`
 * `simd_ffi`
 * `macro_reexport`

 cc rust-lang#22820
Boolean values and small aggregates have a different type in
args/allocas than in SSA values but the intrinsics for volatile and
atomic ops were missing the necessary casts to handle that.

Fixes rust-lang#23550
@Manishearth
Copy link
Member Author

@bors: r+ p=20

@bors
Copy link
Contributor

bors commented Mar 21, 2015

📌 Commit e7d77cf has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors: force

@bors
Copy link
Contributor

bors commented Mar 21, 2015

⌛ Testing commit e7d77cf with merge 1d1f2c0...

@bors
Copy link
Contributor

bors commented Mar 21, 2015

💔 Test failed - auto-mac-64-nopt-t

@dotdash
Copy link
Contributor

dotdash commented Mar 21, 2015

@bors retry

@bors
Copy link
Contributor

bors commented Mar 21, 2015

⌛ Testing commit e7d77cf with merge 1c15687...

@bors
Copy link
Contributor

bors commented Mar 21, 2015

💔 Test failed - auto-mac-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Contributor

bors commented Mar 22, 2015

⌛ Testing commit e7d77cf with merge 28a5342...

@bors
Copy link
Contributor

bors commented Mar 22, 2015

⛄ The build was interrupted to prioritize another pull request.

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Contributor

bors commented Mar 22, 2015

⌛ Testing commit e7d77cf with merge bd0881a...

bors added a commit that referenced this pull request Mar 22, 2015
@bors
Copy link
Contributor

bors commented Mar 22, 2015

💔 Test failed - auto-mac-32-opt

@Manishearth
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Mar 22, 2015

⌛ Testing commit e7d77cf with merge 34ead18...

@bors
Copy link
Contributor

bors commented Mar 22, 2015

💔 Test failed - auto-mac-64-nopt-t

…nkro

 This commit removes the `IndexMut` impls on `HashMap` and `BTreeMap`, in
order to future-proof the API against the eventual inclusion of an
`IndexSet` trait.

Ideally, we would eventually be able to support:

```rust
map[owned_key] = val;
map[borrowed_key].mutating_method(arguments);
&mut map[borrowed_key];
```

but to keep the design space as unconstrained as possible, we do not
currently want to support `IndexMut`, in case some other strategy will
eventually be needed.

Code currently using mutating index notation can use `get_mut` instead.

[breaking-change]

Closes rust-lang#23448

r? @gankro
 Boolean values and small aggregates have a different type in args/allocas than
in SSA values but the intrinsics for volatile and atomic ops were
missing the necessary casts to handle that.

Fixes rust-lang#23550
…s1, r=alexcrichton

 ...ures.

Namely:

 * `box_syntax`
 * `box_patterns`
 * `simd_ffi`
 * `macro_reexport`

cc rust-lang#22820
bors added a commit that referenced this pull request Mar 23, 2015
@bors
Copy link
Contributor

bors commented Mar 23, 2015

⌛ Testing commit b4e9106 with merge 809a554...

@bors
Copy link
Contributor

bors commented Mar 23, 2015

💔 Test failed - auto-mac-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Contributor

bors commented Mar 23, 2015

@bors
Copy link
Contributor

bors commented Mar 23, 2015

💔 Test failed - auto-win-64-nopt-t

@barosl
Copy link
Contributor

barosl commented Mar 23, 2015

Wow, this rollup is very, very unfortunate!

@Manishearth
Copy link
Member Author

@bors: retry

@Manishearth
Copy link
Member Author

@barosl Most of this is just because buildbot died over the weekend.

@bors
Copy link
Contributor

bors commented Mar 23, 2015

@bors
Copy link
Contributor

bors commented Mar 23, 2015

💔 Test failed - auto-win-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Contributor

bors commented Mar 23, 2015

@bors
Copy link
Contributor

bors commented Mar 23, 2015

💔 Test failed - auto-win-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Mar 23, 2015

1 similar comment
@bors bors merged commit b4e9106 into rust-lang:master Mar 23, 2015
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants