Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve E0025, E0046, E0062, E0063 error explanations and add E0370 error explanation #28010

Merged
merged 11 commits into from
Aug 28, 2015
Merged

Improve E0025, E0046, E0062, E0063 error explanations and add E0370 error explanation #28010

merged 11 commits into from
Aug 28, 2015

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez changed the title Improve E0046 Improve E0046 error explanation Aug 26, 2015
@GuillaumeGomez GuillaumeGomez changed the title Improve E0046 error explanation Improve E0046, E0062, E0063 error explanations Aug 26, 2015
@GuillaumeGomez GuillaumeGomez changed the title Improve E0046, E0062, E0063 error explanations Improve E0025, E0046, E0062, E0063 error explanations Aug 26, 2015
@GuillaumeGomez GuillaumeGomez changed the title Improve E0025, E0046, E0062, E0063 error explanations Improve E0025, E0046, E0062, E0063 error explanations and add E0370 error explanation Aug 26, 2015
@GuillaumeGomez
Copy link
Member Author

@Manishearth: I'll stop this PR here. This file should be fine now.

Manishearth
Manishearth reviewed Aug 27, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs
}

fn main() {
let x = Foo { x: 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Keep the fields on a new line

    let x = Foo {
                x: 0,
                x: 0
            };

@Manishearth
Copy link
Member

LGTM modulo nits

@GuillaumeGomez
Copy link
Member Author

@Manishearth: All good !

@Manishearth
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 27, 2015

📌 Commit fbbd874 has been approved by Manishearth

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2015
@Manishearth
Rollup merge of rust-lang#28010 - GuillaumeGomez:patch-2, r=Manishearth
886ea16 
r? @Manishearth
@Manishearth Manishearth mentioned this pull request Aug 27, 2015
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2015
@Manishearth
Rollup merge of rust-lang#28010 - GuillaumeGomez:patch-2, r=Manishearth
a3b32eb 
r? @Manishearth
@Manishearth Manishearth mentioned this pull request Aug 27, 2015
Merged
bors added a commit that referenced this pull request Aug 27, 2015
@bors
Auto merge of #28052 - Manishearth:rollup, r=Manishearth
8dba06a 
- Successful merges: #28010, #28013, #28022, #28029, #28033, #28039, #28045, #28048
- Failed merges:
@bors bors merged commit fbbd874 into rust-lang:master Aug 28, 2015
@GuillaumeGomez GuillaumeGomez deleted the patch-2 branch August 28, 2015 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @Manishearth @bors