Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows-specific comments to testing guide #28022

Merged
merged 1 commit into from
Aug 28, 2015

Conversation

steveklabnik
Copy link
Member

Fixes #27936

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@retep998
Copy link
Member

Don't forget to mention that %ERRORLEVEL% is only when you're inside cmd. Inside an msys environment you use the same thing like you'd use on linux and OS X. In powershell you use either $LASTEXITCODE or $? depending upon whether you want an exist code or just a bool respectively.

@steveklabnik
Copy link
Member Author

@retep998 updated, what do you think?

@retep998
Copy link
Member

It's better.

@alexcrichton
Copy link
Member

@bors: r+ af58e5c

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2015
bors added a commit that referenced this pull request Aug 27, 2015
@bors bors merged commit af58e5c into rust-lang:master Aug 28, 2015
@steveklabnik steveklabnik deleted the gh27936 branch June 19, 2016 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants