Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve internal docs and code style in librustc/front #30621

Closed
wants to merge 3 commits into from
Closed

Improve internal docs and code style in librustc/front #30621

wants to merge 3 commits into from

Conversation

ticki
Copy link
Contributor

@ticki ticki commented Dec 29, 2015

Part of #30520

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jonas-schievink
jonas-schievink reviewed Dec 29, 2015
View reviewed changes
src/librustc/front/map/definitions.rs
@@ -16,6 +16,7 @@ use syntax::ast;
use syntax::parse::token::InternedString;
use util::nodemap::NodeMap;

/// A definition, that defines are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that defines are"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ticki ticki changed the title Improve internal docs in librustc/front Improve internal docs and code style in librustc/front Dec 30, 2015
@steveklabnik
Copy link
Member

This looks good to me, but it'd be nice to get another review as well.

jonas-schievink
jonas-schievink reviewed Feb 8, 2016
View reviewed changes
src/librustc/front/map/definitions.rs
@@ -138,6 +157,7 @@ impl Definitions {
}
}

/// Add a definition with a parrent definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also says "parrent"

@bors
Copy link
Contributor

bors commented Mar 2, 2016

☔ The latest upstream changes (presumably #31937) made this pull request unmergeable. Please resolve the merge conflicts.

@cyplo
Copy link
Contributor

cyplo commented Apr 30, 2016

Hello ! @ticki - is this one still needed ? if so - do you have some time to work on this to get it merged ? thanks a lot !

@ticki
Copy link
Contributor Author

ticki commented Apr 30, 2016

@cyplo No, I have other priorities. Feel free to rebase it and open a PR.

@mrhota
Copy link
Contributor

mrhota commented May 19, 2016

@ticki @steveklabnik @cyplo I think this can be closed. I will do the rebase and issue another PR.

@Aatch
Copy link
Contributor

Aatch commented May 20, 2016

I'll wait until the new PR is opened before closing this one, just in case.

@mrhota mrhota mentioned this pull request May 20, 2016
Merged
@ticki
Copy link
Contributor Author

ticki commented May 20, 2016

Will close.

@ticki ticki closed this May 20, 2016
bors added a commit that referenced this pull request May 22, 2016
@bors
Auto merge of #33752 - mrhota:internal_docs, r=steveklabnik
14d6a10 
Internal docs

This PR is a rebase of #30621. That PR can be closed.

CC @ticki @Aatch @cyplo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aatch Aatch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ticki @rust-highfive @steveklabnik @bors @cyplo @mrhota @Aatch @jonas-schievink