Internal docs #33752
Internal docs #33752
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| body: b, | ||
| id: id, | ||
| span: s, | ||
| attrs: attrs |
There was a problem hiding this comment.
Since you reworked fields indent, why not adding the comma after the last field. 😺
|
@GuillaumeGomez thanks! |
|
Sorry, one last thing to fix. Can you add a "." at the end of every comment you added please? Then you just have to squash your comments and it'll be good. :) |
|
Are periods necessary? They aren't complete sentences. How do I squash and keep @ticki as author? |
Fix some code layout, remove some unnecessary returns, fix typos, punctuation, and comment consistency.
|
@GuillaumeGomez I removed a spurious '.' and added them to the complete sentences in the Squashed! |
I'd put period at the end but let's ask for @steveklabnik's opinion. |
|
Usually, we put periods after the end of a summary, but I'm not sure it's clear about enum docs. This looks fine to me 😄 @bors: r+ rollup |
|
📌 Commit da55fd7 has been approved by |
This PR is a rebase of #30621. That PR can be closed.
CC @ticki @Aatch @cyplo