Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/improve num const docs #34277

Merged
merged 2 commits into from
Jul 7, 2016
Merged

Add/improve num const docs #34277

merged 2 commits into from
Jul 7, 2016

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jun 14, 2016

This adds short summaries to all num consts.

r? @steveklabnik

This adds short summaries to all num consts.
@euclio
Copy link
Contributor

euclio commented Jun 16, 2016

It might be helpful to include an example of EPSILON usage, or at least a comment on why it's useful.

#[stable(feature = "rust1", since = "1.0.0")]
pub const E: f32 = 2.71828182845904523536028747135266250_f32;

/// log2(e)
/// log<sub>2</sub>(e)
Copy link
Member

@GuillaumeGomez GuillaumeGomez Jun 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log2? Nice! :D

@steveklabnik
Copy link
Member

Hey @ollie27 , sorry for the late review. I have one nit, and then this is good to go after!

@ollie27
Copy link
Member Author

ollie27 commented Jun 30, 2016

I've changed the description for EPSILON to be more specific and corrected MIN_EXP which was slightly wrong.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Jul 5, 2016

📌 Commit 2dcfa62 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 5, 2016
Add/improve num const docs

This adds short summaries to all num consts.

r? @steveklabnik
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 5, 2016
Add/improve num const docs

This adds short summaries to all num consts.

r? @steveklabnik
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 6, 2016
Add/improve num const docs

This adds short summaries to all num consts.

r? @steveklabnik
bors added a commit that referenced this pull request Jul 7, 2016
@bors bors merged commit 2dcfa62 into rust-lang:master Jul 7, 2016
@ollie27 ollie27 deleted the docs_num branch July 10, 2016 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants