Rollup of 12 pull requests #34671
Closed
Rollup of 12 pull requests #34671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made the "tuple structs are useless" editorializing a bit weaker and moved it to the end. Feel free to overrule me on that. I also added an example of how to unpack a tuple struct with dot notation, because it came up on IRC. `braced_empty_structs` is stable now, so I updated the example for unit-like structs to use that syntax. Should we show both ways? cc @ubsan r? @steveklabnik or @GuillameGomez
This adds short summaries to all num consts.
updated proper link of cargo doc that contains details about list of options available in semantic versioninig for the dependencies section in Cargo.toml
Add a space between the comma and j in (i, j) to make it look nice.
update documentation of tuple/unit structs I made the "tuple structs are useless" editorializing a bit weaker and moved it to the end. Feel free to overrule me on that. I also added an example of how to unpack a tuple struct with dot notation, because it came up on IRC. `braced_empty_structs` is stable now, so I updated the example for unit-like structs to use that syntax. Should we show both ways? cc @ubsan r? @steveklabnik or @GuillaumeGomez
Add/improve num const docs This adds short summaries to all num consts. r? @steveklabnik
extend+improve HIR types documentation
rustbuild: propagate bootstrap.py '--help' flag Fixes rust-lang#34534. r? @alexcrichton
…, r=GuillaumeGomez Add doc examples for `io::Error::from_raw_os_error`. None
update cargo doc link updated proper link of cargo doc that contains details about list of options available in semantic versioninig for the dependencies section in Cargo.toml
Fix broken markdown link in README.
… r=steveklabnik Clarifies the meaning of the external mutability.
Fix spacing in for loop enumeration example Add a space between the comma and j in (i, j) to make it look nice. This addresses my recent issue rust-lang#34624. 😀
doc: fix and shorten comment
…tion, r=Manishearth Add a section about crate documentation. Fixes rust-lang#34329 ?r @steveklabnik
|
@bors: r+ p=1 |
|
📌 Commit ef8ecf2 has been approved by |
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit ef8ecf2 with merge 1f7b8d8... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry |
|
⌛ Testing commit ef8ecf2 with merge e66a04c... |
|
💔 Test failed - auto-mac-32-opt |
|
@steveklabnik: It seems like a legit error. |
|
Yeah, I'm afraid so this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io::Error::from_raw_os_error. #34612, update cargo doc link #34615, Fix broken markdown link in README. #34619, Clarifies the meaning of the external mutability. #34621, Fix spacing in for loop enumeration example #34625, Fix typos #34626, doc: fix and shorten comment #34636, Add a section about crate documentation. #34667