Point at cause for expectation in return type type error #57723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
changed the title
This comment has been minimized.
This comment has been minimized.
estebank
commented
Jan 18, 2019
| | ^^^^ expected i32, found u32 | ||
| | | ||
| = note: expected type `i32` | ||
| found type `u32` |
There was a problem hiding this comment.
Should these errors also point at the impl Trait return type?
There was a problem hiding this comment.
I think they could and that would be a tad better but the errors aren't much worse off for the lack of it.
| @@ -2,7 +2,7 @@ error[E0308]: mismatched types | |||
| --> $DIR/liveness-forgot-ret.rs:3:19 | |||
| | | |||
| LL | fn f(a: isize) -> isize { if god_exists(a) { return 5; }; } | |||
| | - ^^^^^ expected isize, found () - expected because of this statement | |||
| | - ^^^^^ expected isize, found () | |||
There was a problem hiding this comment.
Yay, drive by fixes :)
davidtwco
approved these changes
Jan 18, 2019
|
@bors r=davidtwco @davidtwco I'll mull on it and maybe have a follow up PR adding that. It should be a fairly small change, but the wording will be tricky to get right. Let's land this as it fixes a regression as well. |
|
📌 Commit 2e06d9c has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 19, 2019
Point at cause for expectation in return type type error Various improvements and fixes for type errors in return expressions. Fix rust-lang#57664.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements and fixes for type errors in return expressions.
Fix #57664.