Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delay_span_bug from qualify_min_const_fn #57736

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Remove delay_span_bug from qualify_min_const_fn #57736

merged 1 commit into from
Jan 19, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Jan 18, 2019

This is causing issues with a new Clippy lint that will be able to
detect possible const functions.

As per rust-lang/rust-clippy#3648 (comment)

r? @oli-obk

@phansch
Remove delay_span_bug from qualify_min_const_fn
79ef971 
This is causing issues with a new Clippy lint that will be able to
detect possible const functions.

As per rust-lang/rust-clippy#3648 (comment)
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Jan 19, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2019

📌 Commit 79ef971 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 19, 2019
@Centril
Rollup merge of rust-lang#57736 - phansch:remove_delay, r=oli-obk
d27224e 
Remove delay_span_bug from qualify_min_const_fn

This is causing issues with a new Clippy lint that will be able to
detect possible const functions.

As per rust-lang/rust-clippy#3648 (comment)

r? @oli-obk
@Centril Centril mentioned this pull request Jan 19, 2019
Merged
bors added a commit that referenced this pull request Jan 19, 2019
@bors
Auto merge of #57761 - Centril:rollup, r=Centril
0c0c585 
Rollup of 4 pull requests

Successful merges:

 - #57452 (Improve docs for Formatter)
 - #57689 (Redo `hir::Stmt`)
 - #57723 (Point at cause for expectation in return type type error)
 - #57736 (Remove delay_span_bug from qualify_min_const_fn)

Failed merges:

r? @ghost
@bors bors merged commit 79ef971 into rust-lang:master Jan 19, 2019
@phansch phansch deleted the remove_delay branch January 20, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phansch @oli-obk @bors @rust-highfive