Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: use format-args-capture and remove unnecessary nested if blocks in some parts of rust_passes #95074

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Refactor: use format-args-capture and remove unnecessary nested if blocks in some parts of rust_passes #95074

merged 1 commit into from
Mar 21, 2022
+61 −78

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Mar 18, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 18, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2022
@TaKO8Ki TaKO8Ki force-pushed the use-format-args-capture-and-remove-unnecessary-nesting-in-rustc-passes branch from c502fc8 to 018e925 Compare March 18, 2022 13:52
@lcnr
Copy link
Contributor

lcnr commented Mar 18, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 18, 2022

📌 Commit 018e925e866b8c9c6807714b77e15d8df5df667a has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2022
@bugadani
Copy link
Contributor

@lcnr

Is it a good idea to approve PRs like this while a similar one might potentially being reverted? #95062

@lcnr
Copy link
Contributor

lcnr commented Mar 18, 2022

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2022
@lcnr
Copy link
Contributor

lcnr commented Mar 18, 2022

didn't know about the revert, considering that the reason was a perf regression

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 18, 2022
@bors
Copy link
Contributor

bors commented Mar 18, 2022

⌛ Trying commit 018e925e866b8c9c6807714b77e15d8df5df667a with merge b3fc9cd52d12e5aa8124ad61828ef7ffa3c37dc1...

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Mar 19, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2022
@TaKO8Ki TaKO8Ki requested a review from joshtriplett March 20, 2022 10:03
@lcnr
Copy link
Contributor

lcnr commented Mar 21, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Mar 21, 2022

⌛ Trying commit c777efe6513eaa452bbd78f9794fec913014c500 with merge ffda9900c208508649f68118720ab65d0e3c8403...

@bors
Copy link
Contributor

bors commented Mar 21, 2022

☀️ Try build successful - checks-actions
Build commit: ffda9900c208508649f68118720ab65d0e3c8403 (ffda9900c208508649f68118720ab65d0e3c8403)

@rust-timer
Copy link
Collaborator

Queued ffda9900c208508649f68118720ab65d0e3c8403 with parent 051d117, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ffda9900c208508649f68118720ab65d0e3c8403): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 21, 2022
@lcnr
Copy link
Contributor

lcnr commented Mar 21, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 21, 2022

📌 Commit c777efe6513eaa452bbd78f9794fec913014c500 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2022
@bors
Copy link
Contributor

bors commented Mar 21, 2022

⌛ Testing commit c777efe6513eaa452bbd78f9794fec913014c500 with merge 784b4391b003bde69913a996d2c2831c8b211fa4...

@lcnr
Copy link
Contributor

lcnr commented Mar 21, 2022

@bors r-

@bors delegate+

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 21, 2022
@bors
Copy link
Contributor

bors commented Mar 21, 2022

✌️ @TaKO8Ki can now approve this pull request

@TaKO8Ki @bjorn3
use format-args-capture and remove unnecessary nested if blocks in …
7262066 
…some parts of rustc_passes

break before the `&&`

Update compiler/rustc_passes/src/check_const.rs

Co-authored-by: bjorn3 <[email protected]>
@TaKO8Ki TaKO8Ki force-pushed the use-format-args-capture-and-remove-unnecessary-nesting-in-rustc-passes branch from 6a2bcf7 to 7262066 Compare March 21, 2022 15:02
@TaKO8Ki TaKO8Ki requested a review from bjorn3 March 21, 2022 15:03
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bjorn3
Copy link
Member

bjorn3 commented Mar 21, 2022

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Mar 21, 2022

📌 Commit 7262066 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2022
@bjorn3 bjorn3 removed their request for review March 21, 2022 15:47
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#95074 - TaKO8Ki:use-format-args-capture-and…
f9e929a 
…-remove-unnecessary-nesting-in-rustc-passes, r=lcnr

Refactor: use `format-args-capture` and remove unnecessary nested if blocks in some parts of `rust_passes`
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 21, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 21, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2022
@bors
Auto merge of rust-lang#95180 - matthiaskrgr:rollup-ai1ch2s, r=matthi…
3c17c84 
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#95074 (Refactor: use `format-args-capture` and remove unnecessary nested if blocks in some parts of `rust_passes`)
 - rust-lang#95085 (Return err instead of ICE)
 - rust-lang#95116 (Add needs-* directives to many tests)
 - rust-lang#95129 (Remove animation on source sidebar)
 - rust-lang#95166 (Update the unstable book with the new `values()` form of check-cfg)
 - rust-lang#95175 (move `adt_const_params`  to its own tracking issue)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e3557e2 into rust-lang:master Mar 21, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 21, 2022
@TaKO8Ki TaKO8Ki deleted the use-format-args-capture-and-remove-unnecessary-nesting-in-rustc-passes branch March 29, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@joshtriplett joshtriplett Awaiting requested review from joshtriplett

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
10 participants
@TaKO8Ki @rust-highfive @lcnr @bors @bugadani @rust-timer @rust-log-analyzer @bjorn3 @joshtriplett @rustbot