Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #95180

Merged
merged 13 commits into from
Mar 21, 2022
Merged

Rollup of 6 pull requests #95180

merged 13 commits into from
Mar 21, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

bjorn3 and others added 13 commits March 19, 2022 16:35
…some parts of rustc_passes

break before the `&&`

Update compiler/rustc_passes/src/check_const.rs

Co-authored-by: bjorn3 <[email protected]>
…-remove-unnecessary-nesting-in-rustc-passes, r=lcnr

Refactor: use `format-args-capture` and remove unnecessary nested if blocks in some parts of `rust_passes`
Return err instead of ICE

Having `escaping_bound_vars` results in ICE when trying to create `ty::Binder::dummy`, to avoid it we return err like the line above. I think this requires a more sophisticated fix, I would love to investigate if mentorship is available 🤓

Fixes rust-lang#95023 and rust-lang#85350
Add needs-* directives to many tests

These are necessary to ignore tests that need features unsupported by cg_clif.
…imation, r=jsha

Remove animation on source sidebar

Fixes rust-lang#95043.

Didn't upload a demo considering how simple it is to test in a browser. :)

r? ``@jsha``
…k, r=petrochenkov

Update the unstable book with the new `values()` form of check-cfg

Forgot to update the unstable book in rust-lang#94362

r? ``@petrochenkov``
…e, r=Dylan-DPC

move `adt_const_params`  to its own tracking issue

the new tracking issue is  rust-lang#95174

r? ``@rust-lang/project-const-generics``
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 21, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Mar 21, 2022

📌 Commit 44200a9 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 21, 2022
@bors
Copy link
Contributor

bors commented Mar 21, 2022

⌛ Testing commit 44200a9 with merge 3c17c84...

@bors
Copy link
Contributor

bors commented Mar 21, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 3c17c84 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 21, 2022
@bors bors merged commit 3c17c84 into rust-lang:master Mar 21, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 21, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3c17c84): comparison url.

Summary: This benchmark run did not return any relevant results. 1 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@matthiaskrgr matthiaskrgr deleted the rollup-ai1ch2s branch July 30, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants