Avoid using unexpected cfgs in user code #1667
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
This is a prerequisites to rust-lang/rust#132577 which wants to enable reporting of the
unexpected_cfgs
lint in external macros and is unfortunately triggering on the macros call generated by stdarch, likeis_x86_feature_detected!
, ...I have computed the list of missing target feature cfgs by comparing:
rg "[ ]+@feature: .*: \"(.*)\";" -r '$1' --no-filename crates/std_detect/src/detect/ | sort | uniq
tests/ui/check-cfg/well-known-values.stderr
1 (from the main Rust repo)(actual.txt, referenced.txt, diff-actual-referenced.txt)
Footnotes
https://github.com/rust-lang/rust/blob/e8c698bb3bdc121ac7f65919bd16d22f6567a3f1/tests/ui/check-cfg/well-known-values.stderr#L177 ↩