Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Repos #4

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Sync Repos #4

merged 3 commits into from
Aug 16, 2022

Conversation

rylev
Copy link
Member

@rylev rylev commented Aug 16, 2022

This follows up on rust-lang/team#801 by syncing repo information encoded in the team repo with GitHub.

The data that is synced is:

  • Repo name/org
  • Repo description
  • Teams and their permissions
  • Bots and their permissions

Given the configuration for the team repo as it is encoded in the team repo, the following would change:
currently the team repo has the bots team as a team on the repo. This change would add each individual bot to the repo.

We could change the encoding in the team repo to allow specifying that a repo should have all bots, but perhaps these bots aren't actually necessary?

Lastly, I haven't actually tested that the write calls to the GitHub API work. If the initial review on this is positive, I will actually give this a real run.

@rylev rylev requested a review from Mark-Simulacrum August 16, 2022 09:38
@Mark-Simulacrum
Copy link
Member

This looks good to me.

I think we should keep bots as separate accounts being added with the automation - IIRC, the team was intended to make it easier for us to propagate adding them, but as we manage things through the repo there's less value in that (maybe zero).

I think we will end up wanting to add individual users, which now that we're controlling permissions via automation seems (more) okay. Teams are still a best practice but creating a team per repository might be a bit much (or maybe is the way to go, with automatic addition, not sure).

@rylev
Copy link
Member Author

rylev commented Aug 16, 2022

re: teams vs adding individuals - I agree that we should allow for adding individuals, but we should try our best to not do so when adding an individual to a team makes more sense.

I'll give this a test, and we can merge once we know everything works.

@rylev
Copy link
Member Author

rylev commented Aug 16, 2022

@Mark-Simulacrum I tested this against the team repo, and everything was synced successfully. Feel free to give it a merge if you'd like.

@Mark-Simulacrum Mark-Simulacrum merged commit 18acf58 into master Aug 16, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the sync-repos branch August 16, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants