Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to encode and fetch repo information #801

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Conversation

rylev
Copy link
Member

@rylev rylev commented Aug 3, 2022

This is the start of being able to control GitHub repos from the team repo.

This introduces one new configuration file type ("repo" located in the "repos" folder) as well as two new endpoint types: /v1/repos.json and /v1/repos/$REPO.json.

The ultimate idea is for this to be fed to sync-team so we can move away from having GitHub admins make changes that are not visible to the rest of the project.

I've only tried to reproduce this repo in the configuration so far.

@rylev rylev requested a review from Mark-Simulacrum August 3, 2022 13:42
@rylev rylev requested a review from pietroalbini August 4, 2022 08:07
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me overall.


[access.teams]
core = "admin"
mods = "maintain"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the access + bots definitions here are OK for now, but I do think we may want some kind of "standard template" for repositories that you can opt out of. For example, rustbot + highfive probably should have access to anything in the org.

repos/team.toml Show resolved Hide resolved
src/schema.rs Outdated Show resolved Hide resolved
src/schema.rs Show resolved Hide resolved
src/validate.rs Outdated Show resolved Hide resolved
@rylev rylev requested a review from Mark-Simulacrum August 12, 2022 16:53
@rylev rylev merged commit 44bf784 into rust-lang:master Aug 15, 2022
@rylev rylev deleted the repos branch August 15, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants