-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(changelog): use 'keep a changelog' format #3590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have become pretty hard to read.
I do agree that now that we have headers for each change type, we shouldn't use the word "add" or "removed" in every entry, but it should still remain readable.
The main issue imo is starting sentences with "On Windows, ...", but then missing the verb, its really odd to read.
My suggestion would be to change the whole "On Windows, ..." to "Windows: ".
Not a native speaker though, @notgull any thoughts?
Yeah, I don't like it as well as I said. |
I agree with adding the indicator before the actual addition. |
The alternative could be putting in the end of the sentence, which also makes it correct, or create sub sections, which is more clean. |
I'm in favor of sub sections. |
I'm fine with whichever option other maintainers prefer. |
fb0d01c
to
8aa675a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a user perspective, I think it's more interesting to see (in order, and roughly in the groups that I think are relevant):
- Large changes or reworks.
- Minor additions, changes, removals or deprecations.
- Changed platform-specific behaviour, with one section per platform.
Re grammar: For projects that use Keep A Changelog, I appreciate when they still add the header name (or something more descriptive) to each entry (e.g. - Added services menu
over - Services menu
). Changelogs are for humans, they don't have to be the absolute minimal they can be.
But don't have that strong of a preference here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I agree with @madsmtm that this is for humans and therefor should be "human-friendly" and not minimal.
Lets wait for our meeting before merging.
8aa675a
to
2879ef3
Compare
I've added a separate commit as alternative way to structure changelog. |
2879ef3
to
b04c1c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have sentences I think a dot at the end would be appropriate.
I missed the last meeting, did you decide to remove subsections or what happened here?
@madsmtm suggested that we should write more correct sentences and subsections ones were harder to read, especially if you want to do inline migrations next to relevant change. go ahead with fixing formatting as you like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with this now.
Links: https://keepachangelog.com/en/1.0.0/ Co-authored-by: Mads Marquart <[email protected]>
bc9fca3
to
46fba81
Compare
Links: https://keepachangelog.com/en/1.0.0/
--
I was thinking maybe we can try to link the changed APIs, since it should be possible now?
I'm also not really liking the way the platform changes look. Maybe use a subsection for them? And for toplevel changes write with a
implemented on X, Y, and Z
?