Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changelog): use 'keep a changelog' format #3590

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

kchibisov
Copy link
Member

Links: https://keepachangelog.com/en/1.0.0/

--

I was thinking maybe we can try to link the changed APIs, since it should be possible now?

I'm also not really liking the way the platform changes look. Maybe use a subsection for them? And for toplevel changes write with a implemented on X, Y, and Z?

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have become pretty hard to read.

I do agree that now that we have headers for each change type, we shouldn't use the word "add" or "removed" in every entry, but it should still remain readable.

The main issue imo is starting sentences with "On Windows, ...", but then missing the verb, its really odd to read.

My suggestion would be to change the whole "On Windows, ..." to "Windows: ".
Not a native speaker though, @notgull any thoughts?

@kchibisov
Copy link
Member Author

My suggestion would be to change the whole "On Windows, ..." to "Windows: ".
Not a native speaker though, @notgull any thoughts?

Yeah, I don't like it as well as I said.

@notgull
Copy link
Member

notgull commented Mar 16, 2024

I agree with adding the indicator before the actual addition.

@kchibisov
Copy link
Member Author

The alternative could be putting in the end of the sentence, which also makes it correct, or create sub sections, which is more clean.

@daxpedda
Copy link
Member

I'm in favor of sub sections.

@notgull
Copy link
Member

notgull commented Mar 17, 2024

I'm fine with whichever option other maintainers prefer.

@kchibisov kchibisov force-pushed the kchibisov/changelog-reformat branch from fb0d01c to 8aa675a Compare March 18, 2024 20:25
@kchibisov kchibisov requested a review from daxpedda March 18, 2024 20:25
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a user perspective, I think it's more interesting to see (in order, and roughly in the groups that I think are relevant):

  • Large changes or reworks.
  • Minor additions, changes, removals or deprecations.
  • Changed platform-specific behaviour, with one section per platform.

Re grammar: For projects that use Keep A Changelog, I appreciate when they still add the header name (or something more descriptive) to each entry (e.g. - Added services menu over - Services menu). Changelogs are for humans, they don't have to be the absolute minimal they can be.

But don't have that strong of a preference here.

@notgull notgull added the C - nominated Nominated for discussion in the next meeting label Mar 25, 2024
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I agree with @madsmtm that this is for humans and therefor should be "human-friendly" and not minimal.
Lets wait for our meeting before merging.

@kchibisov kchibisov force-pushed the kchibisov/changelog-reformat branch from 8aa675a to 2879ef3 Compare March 28, 2024 19:42
@kchibisov
Copy link
Member Author

I've added a separate commit as alternative way to structure changelog.

@kchibisov kchibisov force-pushed the kchibisov/changelog-reformat branch from 2879ef3 to b04c1c6 Compare March 28, 2024 20:46
@kchibisov kchibisov removed the C - nominated Nominated for discussion in the next meeting label Mar 29, 2024
@kchibisov kchibisov requested review from madsmtm and daxpedda March 29, 2024 15:17
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have sentences I think a dot at the end would be appropriate.

I missed the last meeting, did you decide to remove subsections or what happened here?

@kchibisov
Copy link
Member Author

@madsmtm suggested that we should write more correct sentences and subsections ones were harder to read, especially if you want to do inline migrations next to relevant change.

go ahead with fixing formatting as you like.

Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this now.

@kchibisov kchibisov force-pushed the kchibisov/changelog-reformat branch from bc9fca3 to 46fba81 Compare April 12, 2024 17:31
@kchibisov kchibisov merged commit 5a7169c into master Apr 12, 2024
52 checks passed
@kchibisov kchibisov deleted the kchibisov/changelog-reformat branch April 12, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants