Fix changelog entry for #3328 #3613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was incorrectly marked as a breaking change.
kchibisov
requested changes
Mar 28, 2024
| @@ -26,7 +26,7 @@ | |||
| - **Breaking:** Bump MSRV from `1.65` to `1.70`. | |||
| - On Web, add the ability to toggle calling `Event.preventDefault()` on `Window`. | |||
| - **Breaking:** Remove `WindowAttributes::fullscreen()` and expose as field directly. | |||
| - **Breaking:** Rename `VideoMode` to `VideoModeHandle` to represent that it doesn't hold static data. | |||
| - Rename `VideoMode` to `VideoModeHandle` to represent that it doesn't hold static data. The old name is kept, but is now deprecated. | |||
There was a problem hiding this comment.
Then it should be written like a deprecetad change.
|
This is redundant after #3590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was incorrectly marked as a breaking change.