Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bundler target specific default transformations #4253

Merged
merged 3 commits into from
Nov 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove wasm2js example
daxpedda committed Nov 28, 2024
commit 98cb12a8d13b3f73cd2ea0a75cd13fc127b92fc4
4 changes: 0 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -344,10 +344,6 @@ jobs:
- run: rustup update --no-self-update stable && rustup default stable
- run: rustup target add wasm32-unknown-unknown
- run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh -s -- -f
- run: |
curl -L https://github.com/WebAssembly/binaryen/releases/download/version_112/binaryen-version_112-x86_64-linux.tar.gz -sSf > binaryen-version_112-x86_64-linux.tar.gz
tar -xz -f binaryen-version_112-x86_64-linux.tar.gz binaryen-version_112/bin/wasm2js
echo "$PWD/binaryen-version_112/bin" >> $GITHUB_PATH
- run: |
cargo build -p wasm-bindgen-cli
ln -snf `pwd`/target/debug/wasm-bindgen $(dirname `which cargo`)/wasm-bindgen
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -106,7 +106,6 @@ members = [
"examples/wasm-in-wasm",
"examples/wasm-in-wasm-imports",
"examples/wasm-in-web-worker",
"examples/wasm2js",
"examples/weather_report",
"examples/webaudio",
"examples/webgl",
2 changes: 0 additions & 2 deletions crates/example-tests/tests/shell.rs
Original file line number Diff line number Diff line change
@@ -39,8 +39,6 @@ shell_tests! {
raytrace_parallel = "raytrace-parallel",
#[cfg(feature = "stable")]
synchronous_instantiation = "synchronous-instantiation",
#[cfg(feature = "stable")]
wasm2js = "wasm2js",
#[cfg(feature = "nightly")]
#["RUSTUP_TOOLCHAIN" = "nightly"]
wasm_audio_worklet = "wasm-audio-worklet",
12 changes: 0 additions & 12 deletions examples/wasm2js/Cargo.toml

This file was deleted.

17 changes: 0 additions & 17 deletions examples/wasm2js/README.md

This file was deleted.

13 changes: 0 additions & 13 deletions examples/wasm2js/build.sh

This file was deleted.

9 changes: 0 additions & 9 deletions examples/wasm2js/index.html

This file was deleted.

4 changes: 0 additions & 4 deletions examples/wasm2js/index.js

This file was deleted.

13 changes: 0 additions & 13 deletions examples/wasm2js/src/lib.rs

This file was deleted.

1 change: 0 additions & 1 deletion guide/src/SUMMARY.md
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@
- [Small Wasm files](./examples/add.md)
- [Without a Bundler](./examples/without-a-bundler.md)
- [Synchronous Instantiation](./examples/synchronous-instantiation.md)
- [Converting WebAssembly to JS](./examples/wasm2js.md)
- [Importing functions from JS](./examples/import-js.md)
- [Working with `char`](./examples/char.md)
- [js-sys: WebAssembly in WebAssembly](./examples/wasm-in-wasm.md)
38 changes: 0 additions & 38 deletions guide/src/examples/wasm2js.md

This file was deleted.

7 changes: 3 additions & 4 deletions guide/src/reference/browser-support.md
Original file line number Diff line number Diff line change
@@ -15,10 +15,9 @@ also like to be aware of it!

* **IE 11** - `wasm-bindgen` by default requires support for
`WebAssembly`, but no version of IE currently supports `WebAssembly`. You can
support IE by [compiling Wasm files to JS using `wasm2js`][w2js] (you can [see
an example of doing this too](../examples/wasm2js.html)). Note
that at this time no bundler will do this by default, but we'd love to
document plugins which do this if you are aware of one!
support IE by [compiling Wasm files to JS using `wasm2js`][w2js]. Note that
at this time no bundler will do this by default, but we'd love to document
plugins which do this if you are aware of one!

If you find other incompatibilities please report them to us! We'd love to
either keep this list up-to-date or fix the underlying bugs :)