Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bundler target specific default transformations #4253

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Nov 7, 2024

webpack now supports the reference type proposal, so there is no need to not enable reference type transformations when enabled via the target_features section.

See #4235.

@daxpedda daxpedda force-pushed the bundler-reference-types branch from 3a7b746 to d95052d Compare November 7, 2024 16:04
@daxpedda daxpedda marked this pull request as draft November 7, 2024 18:08
@daxpedda
Copy link
Collaborator Author

daxpedda commented Nov 7, 2024

So I did think that this is resolved now in webpack, but I have no clue how to make wasm-pack make use of that fix.
See webpack/webpack#15566.

@daxpedda daxpedda added the help wanted We could use some help fixing this issue! label Nov 7, 2024
@daxpedda daxpedda force-pushed the bundler-reference-types branch 7 times, most recently from 0119a76 to adbbcea Compare November 14, 2024 13:49
@daxpedda
Copy link
Collaborator Author

Fixed in webpack/webpack#18979. Going to wait for it to merge and release.

I also went ahead and removed the wasm2js example, as it doesn't support reference-types and there are no plans to add support.

@daxpedda daxpedda force-pushed the bundler-reference-types branch from adbbcea to 46b627e Compare November 28, 2024 11:55
@daxpedda daxpedda marked this pull request as ready for review November 28, 2024 11:55
@daxpedda
Copy link
Collaborator Author

I decided not to wait for any longer for a webpack release to cut a new release for wasm-bindgen.

@daxpedda daxpedda merged commit c7cab6b into rustwasm:main Nov 28, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We could use some help fixing this issue!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant