Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for mount target before manual unmount #88

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Check for mount target before manual unmount #88

merged 1 commit into from
Nov 16, 2017

Conversation

erquhart
Copy link
Contributor

@erquhart erquhart commented Nov 6, 2017

Closes #87.

@jdreesen jdreesen mentioned this pull request Nov 16, 2017
Closed
ibash
ibash reviewed Nov 16, 2017
View reviewed changes
Copy link
Collaborator

@ibash ibash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly how I'd write it :) #89

@ibash ibash merged commit e48d492 into ryanseddon:master Nov 16, 2017
@ibash
Copy link
Collaborator

ibash commented Nov 16, 2017 •
edited
Loading

Unfortunately I don't have npm permissions, so need to wait for @ryanseddon to publish.
In the meantime - for folks that want this on the v1 branch, feel free to use @superhuman/react-frame-component temporarily.

@erquhart erquhart deleted the patch-1 branch November 27, 2017 23:51
@erquhart
Copy link
Contributor Author

erquhart commented Jan 3, 2018

@ryanseddon can this be published?

@erquhart erquhart mentioned this pull request Jan 3, 2018
Closed
@ryanseddon
Copy link
Owner

Published v2.0.1

@erquhart erquhart mentioned this pull request Mar 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibash ibash ibash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erquhart @ibash @ryanseddon