Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #605

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Fix CI #605

merged 2 commits into from
Jan 20, 2023

Conversation

phil-davis
Copy link
Contributor

  1. Adjust code style to meet current php-cs-fixer
  2. Skip GMT+n timezone test cases on PHP 8.1.14 and 8.2.1

@phil-davis phil-davis mentioned this pull request Jan 20, 2023
Closed
@phil-davis phil-davis requested a review from staabm January 20, 2023 05:42
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #605 (3bef1cf) into master (7b17e07) will increase coverage by 0.22%.
The diff coverage is 98.66%.

@@             Coverage Diff              @@
##             master     #605      +/-   ##
============================================
+ Coverage     98.53%   98.76%   +0.22%     
  Complexity     1865     1865              
============================================
  Files            71       71              
  Lines          4157     5325    +1168     
============================================
+ Hits           4096     5259    +1163     
- Misses           61       66       +5
Impacted Files Coverage Δ
lib/Component/VCard.php 100.00% <ø> (ø)
lib/Component.php 98.75% <75.00%> (+0.12%) ⬆️
lib/TimezoneGuesser/FindFromTimezoneIdentifier.php 92.85% <75.00%> (ø)
lib/BirthdayCalendarGenerator.php 98.18% <100.00%> (+0.22%) ⬆️
lib/Cli.php 97.84% <100.00%> (+0.20%) ⬆️
lib/Component/VAlarm.php 100.00% <100.00%> (ø)
lib/Component/VAvailability.php 100.00% <100.00%> (ø)
lib/Component/VCalendar.php 94.64% <100.00%> (+0.28%) ⬆️
lib/Component/VEvent.php 100.00% <100.00%> (ø)
lib/Component/VFreeBusy.php 100.00% <100.00%> (ø)
... and 66 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis
Copy link
Contributor Author

See #604 for comments and investigations.

@phil-davis phil-davis marked this pull request as ready for review January 20, 2023 05:42
@phil-davis
Copy link
Contributor Author

If we merge this PR, I will also raise an issue to remind us to check in Feb 2023 and verify that the PHP regression has been fixed (and maybe revert the 2nd commit of this PR, that is a workaround for the PHP regression)

staabm
staabm approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@staabm staabm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on it.
I am fine with the new CS rules

@phil-davis phil-davis merged commit 041ceaf into sabre-io:master Jan 20, 2023
@phil-davis phil-davis deleted the fix-ci-20230120 branch January 20, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @staabm