Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code style to meet current php-cs-fixer #604

Closed

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 20, 2023

php-cs-fixer is reporting these. I guess there has been a newer php-cs-fixer version released that is different.

It wants "root" classes and functions to use the leading \ - \InvalidArgumentException \substr

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #604 (a19734a) into master (5f6665f) will not change coverage.
The diff coverage is n/a.

❗ Current head a19734a differs from pull request most recent head bd04f6a. Consider uploading reports for the commit bd04f6a to get more accurate results

@@            Coverage Diff            @@
##             master     #604   +/-   ##
=========================================
  Coverage     98.76%   98.76%           
  Complexity     1865     1865           
=========================================
  Files            71       71           
  Lines          5325     5325           
=========================================
  Hits           5259     5259           
  Misses           66       66           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis
Copy link
Contributor Author

The php unit test fails for PHP 8.1 and 8.2 are because of php/php-src#10218
Timezones GMT+n were broken in PHP 8.1.14 and 8.2.1 released in early January.

Fixed in commit php/php-src@d12ba11
But that will likely not be released until Feb 2023.

@phil-davis
Copy link
Contributor Author

https://github.com/sabre-io/vobject/actions/runs/3964660146/jobs/6793716785

It still uses PHP 8.1.14 in the workflow.

I raised issue shivammathur/setup-php#687 to see if there is some way to successfully select an old PHP patch release.

@phil-davis phil-davis mentioned this pull request Jan 20, 2023
@phil-davis
Copy link
Contributor Author

See #605 for the code that fixes CI.

I will leave this PR here for now, as it demonstrates shivammathur/setup-php#687

@phil-davis phil-davis mentioned this pull request Jan 20, 2023
@phil-davis phil-davis force-pushed the fix-code-style-20230120 branch from a19734a to bd04f6a Compare January 23, 2023 03:45
@phil-davis
Copy link
Contributor Author

Issue shivammathur/setup-php#687
Specifying an old patch release of PHP is not supported.
To work around the problem/regression in PHP 8.1.14 and 8.2.1 I did:
3bef1cf

So this PR is no longer needed, closing.

@phil-davis phil-davis closed this Jan 23, 2023
@phil-davis phil-davis deleted the fix-code-style-20230120 branch January 23, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant