Add support to sign message #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
force-pushed
the
add_sign_messages
branch
from
48bb110 to
9e82522
Compare
moisses89
force-pushed
the
add_sign_messages
branch
2 times, most recently
from
7501afc to
3162c8e
Compare
moisses89
commented
Jan 12, 2024
| if eip712_message_path: | ||
| try: | ||
| message = json.load(open(eip712_message_path, "r")) | ||
| message_bytes = b"".join(eip712_encode(message)) |
There was a problem hiding this comment.
Should I sign the hash of EIP712 or the string hash following EIP191? I'm asking because is the way that the transaction service accepts.
There was a problem hiding this comment.
Sorry, I'm not understanding. You need to sign self.safe.get_message_hash(message_bytes)
moisses89
force-pushed
the
add_sign_messages
branch
from
3162c8e to
7c6c8f2
Compare
|
This PR cannot be merged because have dependencies with:
|
Uxio0
approved these changes
Jan 16, 2024
| if eip712_message_path: | ||
| try: | ||
| message = json.load(open(eip712_message_path, "r")) | ||
| message_bytes = b"".join(eip712_encode(message)) |
There was a problem hiding this comment.
Sorry, I'm not understanding. You need to sign self.safe.get_message_hash(message_bytes)
safe_cli/operators/safe_operator.py
Outdated
| safe_tx = self.hw_wallet_manager.sign_eip712( | ||
| safe_tx, selected_ledger_accounts | ||
| ) | ||
| if len(hw_wallets_signers) > 0: |
There was a problem hiding this comment.
Suggested change
| if len(hw_wallets_signers) > 0: | |
| if len(hw_wallets_signers): |
| + signatures[65 * signer_pos :] | ||
| ) | ||
|
|
||
| if len(hw_wallet_signers) > 0: |
There was a problem hiding this comment.
Suggested change
| if len(hw_wallet_signers) > 0: | |
| if len(hw_wallet_signers): |
| signature_dict["v"], signature_dict["r"], signature_dict["s"] | ||
| ) | ||
| signers.append(eoa_signer.address) | ||
| signer_pos = sorted(signers, key=lambda x: int(x, 16)).index( |
There was a problem hiding this comment.
You can build SafeSignature objects and then use the new method export_signatures on safe-eth-py
| @@ -368,6 +372,13 @@ def remove_delegate(args): | |||
| parser_approve_hash.add_argument("sender", type=check_ethereum_address) | |||
| parser_approve_hash.set_defaults(func=approve_hash) | |||
|
|
|||
| # Sign message | |||
| parser_sign_message = subparsers.add_parser("sign_message") | |||
| group = parser_sign_message.add_mutually_exclusive_group(required=True) | |||
| b"".join(eip712_encode(message)) | ||
| ) | ||
| safe_operator.sign_message(eip712_message_path=eip712_path) | ||
| self.assertTrue(safe_operator.safe.retrieve_is_message_signed(message_hash)) |
There was a problem hiding this comment.
Verify this is False before signing the message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #280
Description
This PR adds support to sign message on-chain and off -chain with Safe Transaction Service.