Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message endpoints requests to safe transaction client #733

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Add message endpoints requests to safe transaction client #733

merged 2 commits into from
Jan 17, 2024

Conversation

moisses89
Copy link
Member

Closes #732

@moisses89 moisses89 requested a review from a team as a code owner January 10, 2024 13:25
@moisses89 moisses89 requested review from fmrsabino, Uxio0 and iamacook and removed request for a team January 10, 2024 13:25
@moisses89
Copy link
Member Author

@Uxio0 I think that is preferable include tests after this issue #734, to avoid duplicate work.

@Uxio0
Copy link
Member

Uxio0 commented Jan 10, 2024

Agree

@moisses89 moisses89 force-pushed the add_message_api_client branch from 10bc22d to 4798942 Compare January 11, 2024 09:27
@moisses89 moisses89 linked an issue Jan 12, 2024 that may be closed by this pull request
Support signing messages safe-global/safe-cli#280
Closed
3 tasks
@moisses89 moisses89 mentioned this pull request Jan 12, 2024
Merged
Uxio0
Uxio0 approved these changes Jan 16, 2024
View reviewed changes
gnosis/safe/api/transaction_service_api.py Outdated
Create safe message on transaction service for provided Safe address

:param safe_address:
:param message:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain that if message is a str it will be encoded using EIP191, and if it's a dictionary it will be encoded using EIP712

gnosis/safe/api/transaction_service_api.py Outdated
)
return True

def get_message(self, safe_message_hash: bytes) -> Dict[str, Any]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this method before def get_messages so this file is more organized

@moisses89 moisses89 force-pushed the add_message_api_client branch from 48c2f46 to 8c651cf Compare January 17, 2024 08:29
@moisses89 moisses89 force-pushed the add_message_api_client branch from 8c651cf to 20d2d9a Compare January 17, 2024 09:10
@moisses89 moisses89 merged commit a0204c6 into master Jan 17, 2024
7 checks passed
@moisses89 moisses89 deleted the add_message_api_client branch January 17, 2024 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@iamacook iamacook Awaiting requested review from iamacook iamacook was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API messages endpoints Support signing messages
2 participants
@moisses89 @Uxio0