Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve webhook migration script #1637

Merged
merged 14 commits into from
Oct 28, 2024

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Oct 25, 2024

Scope of the PR

  • Added VercelBuildtimeTransport which can be used to log information during Vercel build time e.g webhook migrations output. Renamed old attachLoggerVercelTransport to attachLoggerVercelRuntimeTransport.
  • Improved error handling and reporting while migrating webhooks. After this change we skip logging to OTEL. Logs will be available on Vercel, when migration fail we will send error to Sentry.

Related issues

Checklist

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: b180eaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@saleor/apps-logger Patch
app-avatax Patch
@saleor/webhook-utils Minor
cms-v2 Patch
klaviyo Patch
products-feed Patch
search Patch
smtp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 0:26am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 0:26am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 0:26am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
saleor-app-cms ⬜️ Skipped (Inspect) 💬 Add feedback Oct 28, 2024 0:26am
saleor-app-klaviyo ⬜️ Skipped (Inspect) Oct 28, 2024 0:26am
saleor-app-smtp ⬜️ Skipped (Inspect) 💬 Add feedback Oct 28, 2024 0:26am

@vercel vercel bot temporarily deployed to Preview – saleor-app-cms October 25, 2024 12:40 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-klaviyo October 25, 2024 12:40 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-products-feed October 25, 2024 12:40 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-smtp October 25, 2024 12:40 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-search October 25, 2024 12:40 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-cms October 28, 2024 09:38 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-search October 28, 2024 09:39 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-klaviyo October 28, 2024 09:39 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-products-feed October 28, 2024 09:39 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-smtp October 28, 2024 09:39 Inactive
poulch
poulch previously approved these changes Oct 28, 2024
@krzysztofzuraw krzysztofzuraw merged commit 2f37f07 into main Oct 28, 2024
16 checks passed
@krzysztofzuraw krzysztofzuraw deleted the fix-how-we-log-info-about-webhooks branch October 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants