Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 49329 #52212

Merged
merged 1 commit into from
Mar 16, 2019
Merged

Fix 49329 #52212

merged 1 commit into from
Mar 16, 2019

Conversation

mchugh19
Copy link
Contributor

What does this PR do?

Wraps mkdir operation in test check

What issues does this PR fix or reference?

#49329

Previous Behavior

# salt-call state.single file.append /tmp/foo/bar text="bar" makedirs=True test=True
[ERROR   ] /tmp/foo/bar: file not found
local:
----------
          ID: /tmp/foo/bar
    Function: file.append
      Result: False
     Comment: /tmp/foo/bar: file not found
     Started: 22:11:50.803036
    Duration: 7.558 ms
     Changes:

Summary for local
------------
Succeeded: 0
Failed:    1
------------
Total states run:     1
Total run time:   7.558 ms

Created /tmp/foo directory

New Behavior

# salt-call state.single file.append /tmp/foo/bar text="bar" makedirs=True test=True
local:
----------
          ID: /tmp/foo/bar
    Function: file.append
      Result: None
     Comment: File /tmp/foo/bar is set to be created
     Started: 22:25:49.798269
    Duration: 0.72 ms
     Changes:

Summary for local
------------
Succeeded: 1 (unchanged=1)
Failed:    0
------------
Total states run:     1
Total run time:   0.720 ms

Tests written?

No

Commits signed with GPG?

No

@garethgreenaway garethgreenaway added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Mar 16, 2019
@garethgreenaway garethgreenaway merged commit 0068482 into saltstack:develop Mar 16, 2019
garethgreenaway pushed a commit to garethgreenaway/salt that referenced this pull request Mar 16, 2019
@garethgreenaway garethgreenaway added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Mar 16, 2019
@mchugh19 mchugh19 deleted the file-state branch March 16, 2019 05:29
garethgreenaway added a commit that referenced this pull request Mar 21, 2019
mchugh19 added a commit to mchugh19/salt that referenced this pull request Jan 11, 2020
dwoz added a commit that referenced this pull request Jan 12, 2020
port #52212 to master - suggested for Neon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants