port #52212 to master - suggested for Neon #55843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ports #52212 to master
This change has been backported to 2018.3, so it should really be fixed for Neon as well.
What issues does this PR fix or reference?
Continues to close #49329 and ports #52212 to master
Previous Behavior
Previous behavior mistakenly made changes when
test=Truewas passed.New Behavior
Wrap changes with a test check
Tests written?
No
Previous behavior mistakenly made changes when
test=Truewas passed. This PR corrects that behavior, and it seems silly to create tests for expected behavior or to check accidently broken bits.Commits signed with GPG?
No