Bugs/49147 ipc subscriber develop #52417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmitryKuzmenko Can you merge these changes into your branch here? |
|
bump @DmitryKuzmenko |
|
@Ch3LL Working. |
|
@Ch3LL I've reverted the PR #51963 (except the test) and re-implemented removing of singletons for IPCMessageSubscriber class. The PR is here: #52564. It passed the tests so now it could be pushed to 2018.3 and merged forward to 2019.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port of #51963 to develop.
What issues does this PR fix or reference?
Fixes merge forward from 2018.3 to develop #52398
Tests written?
Yes
Commits signed with GPG?
Yes