Simplify IPCClient and prevent corrupt messages (Turn 2) #52564
Merged
+117
−162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since we decided to remove singletons from IPC transport I've reverted my approach implementing the subscriber pattern as a local singleton service and multiple subscribers for it because if we don't need singleton we can just be subscribers.
Also I've removed singleton from the reverted subscriber and slightly simplified the code (in comparison to the original one, before mine and @dwoz fixes)
What issues does this PR fix or reference?
Reverts #51963
Related to #52445
Tests written?
Yes (I haven't reverted the tests because them are useful)
Commits signed with GPG?
Yes