Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify IPCClient and prevent corrupt messages (Turn 2) #52564

Merged
merged 5 commits into from
Apr 18, 2019

Conversation

DmitryKuzmenko
Copy link
Contributor

What does this PR do?

Since we decided to remove singletons from IPC transport I've reverted my approach implementing the subscriber pattern as a local singleton service and multiple subscribers for it because if we don't need singleton we can just be subscribers.
Also I've removed singleton from the reverted subscriber and slightly simplified the code (in comparison to the original one, before mine and @dwoz fixes)

What issues does this PR fix or reference?

Reverts #51963
Related to #52445

Tests written?

Yes (I haven't reverted the tests because them are useful)

Commits signed with GPG?

Yes

@dwoz
Copy link
Contributor

dwoz commented Apr 16, 2019

Unverified

This user has not yet uploaded their public signing key.
This reverts commit 37aeba3.

Unverified

This user has not yet uploaded their public signing key.
This reverts commit 684bf58.

Unverified

This user has not yet uploaded their public signing key.
…e process"

This reverts commit 710ab50.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants