Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Fix salt user login shell path in Debian packages #64378

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

clayoster
Copy link
Contributor

@clayoster clayoster commented May 28, 2023

There are cases where /sbin/nologin doesn't exist on Debian servers. This will set /usr/sbin/nologin on new installs and update it on existing installs during the next upgrade as well.

What does this PR do?

What issues does this PR fix or reference?

Fixes: #64377

Previous Behavior

In cases where /sbin/nologin doesn't exist on Debian servers, running salt-master -l debug will fail because the login shell is not available.

New Behavior

The "salt" user login shell will be set to /usr/sbin/nologin which is the Debian default.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@clayoster clayoster requested a review from a team as a code owner May 28, 2023 23:50
@clayoster clayoster requested review from whytewolf and removed request for a team May 28, 2023 23:50
@welcome
Copy link

welcome bot commented May 28, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix salt user login shell path in Debian packages [master] Fix salt user login shell path in Debian packages May 28, 2023
s0undt3ch
s0undt3ch previously approved these changes May 29, 2023
@s0undt3ch s0undt3ch added the backport:3006.x Backport PR to 3006.x branch label May 29, 2023
@clayoster clayoster temporarily deployed to ci May 29, 2023 06:22 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 29, 2023 06:22 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 29, 2023 06:23 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 29, 2023 07:26 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 29, 2023 07:26 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 29, 2023 07:26 — with GitHub Actions Inactive
@clayoster clayoster requested a review from s0undt3ch May 29, 2023 16:21
@clayoster
Copy link
Contributor Author

I noticed one of the CI checks was failing because there was no newline in the changelog file. Added commit 58dd833 to fix that.

@clayoster clayoster temporarily deployed to ci May 29, 2023 17:52 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 29, 2023 17:53 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 29, 2023 17:56 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch requested review from dwoz and Ch3LL May 30, 2023 07:51
@clayoster clayoster temporarily deployed to ci May 30, 2023 08:05 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 30, 2023 08:08 — with GitHub Actions Inactive
@clayoster clayoster temporarily deployed to ci May 30, 2023 08:08 — with GitHub Actions Inactive
Ch3LL
Ch3LL previously approved these changes May 30, 2023
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some kind of regression test for this.

Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some kind of regression test for this.

whytewolf
whytewolf previously approved these changes Jun 7, 2023
@Ch3LL Ch3LL merged commit f4efa4f into saltstack:3006.x Aug 16, 2023
@welcome
Copy link

welcome bot commented Aug 16, 2023

Congratulations on your first PR being merged! 🎉

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
3006.x

Questions ?

Please refer to the Backport tool documentation

@github-actions
Copy link

💔 All backports failed

Status Branch Result
complete The branch "complete" does not exist

Manual backport

To create the backport manually run:

backport --pr 64378

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 20:46 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 20:46 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 20:46 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 20:46 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 21:00 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 21:01 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 21:55 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 21:55 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 21:55 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 21:55 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 21:55 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 21:55 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 22:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 22:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 22:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 22:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 22:07 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci September 24, 2023 22:07 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The "salt" user login shell should be /usr/sbin/nologin on Debian
7 participants