-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Fix salt user login shell path in Debian packages #64378
[3006.x] Fix salt user login shell path in Debian packages #64378
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
I noticed one of the CI checks was failing because there was no newline in the changelog file. Added commit 58dd833 to fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have some kind of regression test for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have some kind of regression test for this.
Congratulations on your first PR being merged! 🎉 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
There are cases where /sbin/nologin doesn't exist on Debian servers. This will set /usr/sbin/nologin on new installs and update it on existing installs during the next upgrade as well.
What does this PR do?
What issues does this PR fix or reference?
Fixes: #64377
Previous Behavior
In cases where /sbin/nologin doesn't exist on Debian servers, running
salt-master -l debug
will fail because the login shell is not available.New Behavior
The "salt" user login shell will be set to /usr/sbin/nologin which is the Debian default.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes