Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix await None error #66277

Closed
wants to merge 5 commits into from
Closed

[master] Fix await None error #66277

wants to merge 5 commits into from

Conversation

merlinz01
Copy link
Contributor

@merlinz01 merlinz01 commented Mar 26, 2024

What does this PR do?

Adds @tornado.gen.coroutine decorator to Minion._handle_payload method (also ProxyMinion and Syndic).

What issues does this PR fix or reference?

Fixes: #66177

Previous Behavior

Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/transport/zeromq.py", line 394, in consume
     await callback(msg)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/channel/client.py", line 484, in wrap_callback
    await callback(decoded)
TypeError: object NoneType can't be used in 'await' expression

New Behavior

No errors!

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@merlinz01 merlinz01 requested a review from a team as a code owner March 26, 2024 20:48
@merlinz01 merlinz01 requested review from twangboy and removed request for a team March 26, 2024 20:48
Copy link

welcome bot commented Mar 26, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix await None error [master] Fix await None error Mar 26, 2024
@twangboy twangboy requested a review from dwoz March 27, 2024 18:44
@tjyang
Copy link
Contributor

tjyang commented Mar 27, 2024

#66282, I opened this ticket to track time out issue.

@dwoz
Copy link
Contributor

dwoz commented Mar 27, 2024

Please hold off on merging this until I have a chance to look at it in more detail. See also #66231

@merlinz01
Copy link
Contributor Author

Have updated this PR according to the recommendations in this comment.

@dwoz
Copy link
Contributor

dwoz commented May 1, 2024

superseded by #66335

@dwoz dwoz closed this May 1, 2024
@merlinz01 merlinz01 deleted the fix-await-none-error branch May 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installed 3007 TypeError: object NoneType can't be used in 'await' expression
4 participants