[3007.x] PubChannel on_recv callback must be a coroutine #66335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
|
Looks like a duplicate of PR #66277. |
dwoz
force-pushed
the
issue/3007.x/66177
branch
from
035f527 to
d9ac533
Compare
dwoz
changed the title
s0undt3ch
approved these changes
May 1, 2024
3 tasks
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make sure on_recv handlers are co-routines. This fixes several errors seen by minions and syndics.
What issues does this PR fix or reference?
Fixes: #66177 #66237
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.