Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use default collection img if one is set #2307

Closed
wants to merge 1 commit into from

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Aug 28, 2024

Summary

When a user sets a default image in Settings, it should override the true default image (that comes from Hyrax). Previously, the collection image did not change even after the user set one. The logic needed to be swapped.

Issue:

Expected Behavior

When no default image is set, it'll use the application's default image. (this was tested using Pals knapsack, who've customized their default image to be the blocks instead of a blank file)

Screenshot 2024-08-28 at 08-02-14 Show Appearance __ Hyku Commons

Screenshot 2024-08-28 at 11-32-43 Collections

When a default image is set in the settings, it should override the application's default image

image

Screenshot 2024-08-28 at 11-37-13 Collections

Notes

When a user sets a default image in Settings, it should override the true default image (that somes from Hyrax). Previously, the collection image did not change even after the user set one.

Issue:
- notch8/palni_palci_knapsack#76
@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Aug 28, 2024
@ShanaLMoore ShanaLMoore changed the title 🐛 Uses default collection img if one is set 🐛 Use default collection img if one is set Aug 28, 2024
@ShanaLMoore ShanaLMoore marked this pull request as draft August 28, 2024 19:19
Copy link

Test Results

    3 files  ±0      3 suites  ±0   18m 9s ⏱️ +48s
2 032 tests ±0  1 982 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 059 runs  ±0  2 007 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit 44f74b3. ± Comparison against base commit af9b198.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 1990d270-5121-4427-8390-5954c15a94ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 974f6411-9734-4333-bf48-62d6bcbf4b4d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 619b683e-90c9-4d66-a455-3a2eafd5b2f0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 0985cd2b-671e-41b7-a479-a820346fcab4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 9b67207f-18bb-4edc-9707-3222059ad3db
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit ebb79975-4155-4b6b-aae0-e71bc430c712
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 17b883ea-1717-48b2-96e2-fe6372956353
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 92001278-deae-41de-bac1-617a976a3043
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 3d843af2-67ee-4904-97e4-8b4d50eb5bb1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 0d5abbd3-c9dc-4f13-85bb-c3d59ad524aa
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 9f001fce-c66e-462c-bf4a-d421480dc981
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e3ca20fe-3cca-458c-838d-fd885f4834bb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 8efc5dde-f97a-456c-8fb6-94fb4b4e1ec6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update cefa16da-3fbe-4e4e-8d76-460b895b7b66
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy c340219d-0c40-4417-8dff-548b15493733
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 18935455-bef0-466e-88a1-bb062c994569
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read a35b23fe-2fee-4b77-a20b-94d2d0eee525
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 804084f3-f9d7-4e3f-b4c2-0a0f3ec8e41f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 1eedd1a4-5cb5-49d5-9589-214fa72d51e5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 08e2803f-eea0-43da-98be-42f6de2216c9
…

@orangewolf orangewolf deleted the i76-default-collection-image branch December 23, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant