Default Collection image missing

[ndroark]

Summary

The standard default collection image (the stack of cubes) is missing, collections without a thumbnail set show a common file placeholder image.

Currently showing

What should show

Acceptance Criteria

• the default thumbnail for collections is the stack of cubes image

[ShanaLMoore]

Updated submodule

Tested on DEMO

DEFAULT COLLECTION IMAGE set:

DEFAULT COLLECTION IMAGE rendered:

[ndroark]

I am now seeing the default collection image in some cases, but newly created collections are populating with the file image above. Example: https://demo.palni-palci-staging.notch8.cloud/dashboard/collections/2ae0d227-d53d-4957-b72f-18ee5e55e64b?locale=en

[ShanaLMoore]

@ndroark for this tenant, the default collection image wasn't set.

When I updated it from the Admin Dashboard > Settings > Appearances > Default Images. Save and refresh the collection page, the expected image appears. Once set, all new collections will use this default.

Otherwise it falls back to the icon defined by Hyrax or Hyku (I'd have to chase it down). Will this behavior suffice?

[ndroark]

Is this the icon defined by Hyrax?

In our standard production repo, the three blocks icon is what collections show by default unless the default icon is updated manually by the user.

[ShanaLMoore]

In our standard production repo, the three blocks icon is what collections show by default unless the default icon is updated manually by the user.

Ah ok, so the true default is what we need to change. This should be the default even when the user hasn't set one.

Got it, we can re work this

[ShanaLMoore]

To report back, I can confirm the true default was coming from Hyrax. I'll override it with your request.

# app/helpers/application_helper.rb

  # Return collection thumbnail formatted for display:
  #  - use collection's branding thumbnail if it exists
  #  - use site's default collection image if one exists
  #  - fallback to Hyrax's default image
  def collection_thumbnail(document, _image_options = {}, url_options = {})
    view_class = url_options[:class]
    # The correct thumbnail SHOULD be indexed on the object
    return image_tag(document['thumbnail_path_ss'], class: view_class, alt: alttext_for(document)) if document['thumbnail_path_ss'].present?

    # If nothing is indexed, we just fall back to site default
    return image_tag(Site.instance.default_collection_image&.url, alt: alttext_for(document), class: view_class) if Site.instance.default_collection_image.present?

    # fall back to Hyrax default if no site default
    tag.span("", class: [Hyrax::ModelIcon.css_class_for(::Collection), view_class],
                 alt: alttext_for(document))
  end

[ShanaLMoore]

@ndroark in the list of current priorities, where would this fit?

[ShanaLMoore]

QA: Please note, if it looks like pictures aren't updating after save, check to see that the reindex jobs have completed.

[laritakr]

QA Results ✅

• Default thumbnail shows
• Custom thumbnail shows
• Changing the tenant's default collection thumbnail works
• Removing the tenant's default collection reverts to the stack of cubes overall default image