Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace URL parser with RegEx with configurable path prefix #23

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

mbklein
Copy link
Member

@mbklein mbklein commented Jul 13, 2022

This PR:

  • changes the URL parser so that instead of popping path segments off the end of the URL and assuming the image ID is only one segment, it uses a configurable path prefix with a default of /iiif/2/
  • increases test coverage
  • removes unreachable code paths

This will enable samvera/serverless-iiif#52 and samvera/serverless-iiif#73 to be fixed a lot more easily.

I've included a major version bump because it represents a potentially breaking change to previous parsing behavior.

@mbklein mbklein requested a review from theiawolfe July 13, 2022 15:27
@mbklein mbklein force-pushed the flexible-path-prefix branch from c04af2e to 2a96ad4 Compare July 13, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants