Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 MB fallback fails for IIIF IDs that have a % in them (encoded /) #52

Closed
tpendragon opened this issue Oct 21, 2021 · 4 comments
Closed

Comments

@tpendragon
Copy link
Contributor

We had to fix this by installing a viewer-request function (https://github.com/pulibrary/serverless-iiif/blob/main/src_edge/index.js), the comment in there describes the issue best I think:

  // The lambda will write to an S3 bucket and fall back to it if the image is
  // too big. Unfortunately the object URL for S3 replaces % with %25, so
  // fallback doesn't work. So rewrite % to %25, and then the lambda will use
  // x-original-uri, while S3 will have the right request URI.
@mbklein
Copy link
Member

mbklein commented Jun 23, 2022

@tpendragon Can you provide steps to reproduce this issue? Even though you have a workaround, I'd like to fix it in core, but I've forgotten exactly what the issue is.

@tpendragon
Copy link
Contributor Author

I think you just have to put a file in an s3 bucket with a folder and then try to render it

@tpendragon
Copy link
Contributor Author

A large file that has to fall back to cache

@mbklein
Copy link
Member

mbklein commented Jul 18, 2022

I believe this was fixed by samvera/node-iiif#23 (via 84da4d6). I'm closing this issue but @tpendragon if you deploy the latest version and find that this is still an issue, feel free to reopen.

@mbklein mbklein closed this as completed Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants